fix: trim responses after think blocks - #346
Open
xkam7ar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #345.
Summary
Trim the response again after removing a complete
<think>...</think>block. This lets the existing Markdown-fence cleanup recognize JSON fences exposed behind leading whitespace.The correction affects the shared response normalizer used by resume evaluation, project generation, and PDF section extraction.
Regression coverage
The new standard-library test covers:
The third case raised
JSONDecodeErrorbefore the one-line fix and passes afterward.Validation
git diff --check: passedReal-provider and PDF pipeline smoke checks were not run because they require external models, documents, or credentials. No prompt, provider, dependency, API, or configuration behavior changes.