Add remaining type hints and linter checks for the project #32

laracroft37 · 2024-09-09T13:02:44Z

Include a minimal mypy config file and linting workflow too.

pevogam

Great steps forward, I left any remaining requested changes as comments.

avocado_i2n/cartgraph/graph.py

avocado_i2n/cartgraph/node.py

avocado_i2n/cartgraph/graph.py

avocado_i2n/cartgraph/node.py

pevogam

Some extra comments wrapped as an extra review of the requested changes

avocado_i2n/cartgraph/object.py

avocado_i2n/cmd_parser.py

avocado_i2n/plugins/auto.py

avocado_i2n/plugins/manu.py

avocado_i2n/params_parser.py

avocado_i2n/vmnet/netconfig.py

avocado_i2n/intertest_setup.py

avocado_i2n/states/setup.py

avocado_i2n/cartgraph/node.py

Include a minimal mypy config file and CI workflow too.

Update the traditional unit testing for isolation of previous problems.

pevogam

Ok, this looks good now and thanks for all the effort here!

laracroft37 force-pushed the ci-linting branch 3 times, most recently from 9d97b86 to 147b05a Compare September 9, 2024 13:10

laracroft37 changed the title ~~Add type hint annotations for the remaining modules and subpackages~~ Add remaining type hints and linter checks for the project Sep 9, 2024

laracroft37 force-pushed the ci-linting branch 8 times, most recently from 4b8ce44 to 34f89a0 Compare September 10, 2024 14:56

pevogam assigned laracroft37 Sep 11, 2024

pevogam added the good first issue Good for newcomers label Sep 11, 2024

pevogam requested changes Sep 12, 2024

View reviewed changes

laracroft37 force-pushed the ci-linting branch 13 times, most recently from b71a0ed to f555574 Compare September 19, 2024 16:35

laracroft37 force-pushed the ci-linting branch 2 times, most recently from bc69842 to a2db0b0 Compare September 22, 2024 12:31

laracroft37 force-pushed the ci-linting branch 8 times, most recently from eb8f876 to 1bb5cf6 Compare September 22, 2024 19:01