Skip to content

Commit

Permalink
Fix confusing coverage script behavior ignoring some errors
Browse files Browse the repository at this point in the history
We would prefer to have the coverage report generated in all cases
and the problems with coverage in the bash script are not reproducible
in other environments so let's prioritize the coverage data first.
  • Loading branch information
pevogam committed May 7, 2024
1 parent d96e6e4 commit bd6d5eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/coverage_analysis.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ $coverage run --source="$libpath" -m unittest discover -v -s ../tests/
$coverage report -m -i
# codecov is poorly documented and even in verbose mode and various directory changes
# won't tell us where it runs the xml command and why it ends up not finding it
$coverage xml
$coverage xml -i
if [[ $submit == 1 ]]; then codecov; fi

0 comments on commit bd6d5eb

Please sign in to comment.