Merge pull request #162 from emelnychenko/patch-1

PHP 7.2 type warning
intuit · Jul 20, 2018 · 8d51279 · 8d51279
2 parents 2943e4d + bb70b35
commit 8d51279
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/ReportService/ReportService.php b/src/ReportService/ReportService.php
@@ -1015,7 +1015,7 @@ private function useMinorVersion()
     private function getReportQueryParameters()
     {
         $uriParameterList = array();
-        $uriParameterString = null;
+        $uriParameterString = '';
 
         if (!is_null($this->report_date)) {
             array_push($uriParameterList, array("report_date", $this->getReportDate()));
@@ -1156,7 +1156,7 @@ private function getReportQueryParameters()
 
 
         foreach ($uriParameterList as $uriParameter) {
-            if (sizeof($uriParameterString) > 0) {
+            if (strlen($uriParameterString) > 0) {
                 $uriParameterString .= "&";
             }
             $uriParameterString .= $uriParameter[0];
@@ -1178,7 +1178,7 @@ public function executeReport($reportName)
         $querySeparator = "?";
         $reportQueryParameters = $this->getReportQueryParameters();
 
-        if ($reportQueryParameters) {
+        if (strlen($reportQueryParameters) > 0) {
             $httpRequestUri = implode(CoreConstants::SLASH_CHAR, array('company', $this->serviceContext->realmId, $urlResource, $reportName, $querySeparator));
             $httpRequestUri .=  $reportQueryParameters;
         } else {