Revert change "Set default use SSL to false" #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agileware-justin I can't see from the commit message or from the release on why this was done, but I agree with you, I will merge the PR when I do a release next. Thanks! |
|
Certificates need to be updated before merging. |
agileware-justin
force-pushed
the
CIVIQBO-67
branch
from
54fd516 to
2d19800
Compare
|
Have updated this PR. Fixed a couple of spellings mistakes in the code. And fixed the two locations where the QBO API code disables SSL verification when calling OAuth1 and OAuth2 API calls. Please review @sujitharamadass @bsivalingam OAuth1APICall OAuth2APICall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the change to disable SSL verification in QBO API call interface.
See 670e020
Agileware Ref: CIVIQBO-67