Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering support to slack plugin #2376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adierkens
Copy link
Collaborator

@adierkens adierkens commented Jul 13, 2023

What Changed

Adding the ability to filter out which messages should be posted to slack

Why

We'd like to cross-post our release to multiple channels based on which packages changed, or for particular keywords.

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.gz
auto-macos--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.gz
auto-win.exe--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/auto@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/core@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/package-json-utils@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/all-contributors@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/brew@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/chrome@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/cocoapods@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/conventional-commits@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/crates@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/docker@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/exec@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/first-time-contributor@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/gem@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/gh-pages@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/git-tag@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/gradle@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/jira@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/magic-zero@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/maven@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/microsoft-teams@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/npm@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/omit-commits@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/omit-release-notes@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/pr-body-labels@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/protected-branch@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/released@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/s3@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/sbt@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/slack@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/twitter@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/upload-assets@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/version-file@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
npm install @auto-canary/vscode@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
# or 
yarn add @auto-canary/bot-list@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/auto@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/core@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/package-json-utils@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/all-contributors@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/brew@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/chrome@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/cocoapods@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/conventional-commits@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/crates@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/docker@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/exec@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/first-time-contributor@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/gem@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/gh-pages@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/git-tag@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/gradle@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/jira@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/magic-zero@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/maven@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/microsoft-teams@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/npm@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/omit-commits@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/omit-release-notes@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/pr-body-labels@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/protected-branch@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/released@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/s3@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/sbt@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/slack@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/twitter@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/upload-assets@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/version-file@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0
yarn add @auto-canary/vscode@10.47.0--canary.2376.1f41411505f36958dfa6efe638f9ad6a1f24443c.0

@github-actions github-actions bot added the minor Increment the minor version when merged label Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #2376 (00f43aa) into main (d2785b9) will decrease coverage by 0.18%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
- Coverage   80.62%   80.45%   -0.18%     
==========================================
  Files          69       69              
  Lines        5668     5678      +10     
  Branches     1330     1276      -54     
==========================================
- Hits         4570     4568       -2     
- Misses        718      723       +5     
- Partials      380      387       +7     
Impacted Files Coverage Δ
plugins/slack/src/index.ts 74.57% <33.33%> (-5.07%) ⬇️

... and 2 files with indirect coverage changes

@adierkens adierkens marked this pull request as ready for review April 8, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant