Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make email comparison for SAML case insensitive #1173

Open
wants to merge 4,856 commits into
base: main
Choose a base branch
from
Open

fix: make email comparison for SAML case insensitive #1173

wants to merge 4,856 commits into from

Conversation

fastlorenzo
Copy link
Contributor

Email comparison when doing SSO with SAML is currently case sensitive.
However, email addresses should be treated as case insensitive.

This PR makes sure that:

  1. Email address of each user is saved as lowercase in the database
  2. Email address received from IDP when doing SSO is converted to lowercase prior to comparison

eric-intuitem and others added 30 commits November 29, 2024 10:48
@eric-intuitem @ab-smith
Add ebios-rm matrix (intuitem#1098)
086ea2f 
Co-authored-by: Abderrahmane Smimite <[email protected]>
@ab-smith
formatter
54b6da9
@ab-smith
starting point
04ef58a
@ab-smith
clickable metrics (intuitem#1093)
282df7b
@nas-tabchiche
Exclude third party users from editors count
0708bba
@Mohamed-Hacene
Ca 614 set up huey (intuitem#1088)
8dc4827
@Mohamed-Hacene
Exclude third party users from editors count (intuitem#1100)
badec5e
@Mohamed-Hacene
feat: add proof, privacy and safety in scenario qualifications
4a77427
@Mohamed-Hacene
chore: fix indent
7639731
@Mohamed-Hacene
chore: update translations with Fink 🐦
a6dbe6d
@Mohamed-Hacene
feat: keep order of security objectives
08decdb
@Mohamed-Hacene
historical data prep (intuitem#1079)
ceb8225
@ab-smith
Basic tile styling
c32cad4
@Mohamed-Hacene
feat: update read view of a requirement
867dbed
@ab-smith
Merge branch 'main' into CA-616-serialize-requirement-node-fields-in-…
9c8bb74 
…requirement-assessment
@nas-tabchiche
Update risk scenarios qualifications (intuitem#1101)
115dbd8
@Mohamed-Hacene
fix: flash mode
10ae382
@ab-smith
Add requested metrics
7c7f08c
@ab-smith
Merge branch 'main' into ebios-rm-tiles
e3c8065
@ab-smith
Add extra metrics (intuitem#1103)
23ac366
@ab-smith
wip
5683520
@ab-smith
wip
f15e8e0
@ab-smith
Fix the Ebios RM matrix
00fbe1b
@ab-smith
Fix the Ebios RM matrix (intuitem#1104)
394f9ef
@eric-intuitem
feat: keep order of security objectives (intuitem#1102)
4235018
@eric-intuitem
Update startup-tests.yml
a65cc2e 
increase timeout
show warning to guide resolution
@nas-tabchiche
Update startup-tests.yml (intuitem#1106)
6584103
@ab-smith
Add core objects illustration (intuitem#1108)
e34df4c
@eric-intuitem
update licenses (intuitem#1109)
e3e4bca
@fastlorenzo
Make Login UI responsive (intuitem#1107)
ba95c9c 
Signed-off-by: fastlorenzo <[email protected]>
nas-tabchiche and others added 20 commits December 9, 2024 20:59
@nas-tabchiche
improve vulnerability display (intuitem#1166)
a0fbdda
@Mohamed-Hacene
feat: add attack-paths and stakeholders folder foreignKey
a75fefe
@eric-intuitem
Hotfix for mail language (intuitem#1165)
a56a1a6
@nas-tabchiche
chore: Remove unused props
8b536f9
@Mohamed-Hacene
feat : add ebios foreignKeyFields endpointUrls
96ba91c
@nas-tabchiche
Workshop 3 (intuitem#1139)
020b34a
@Mohamed-Hacene @nas-tabchiche
feat: workshop 2
f67b367
@Mohamed-Hacene @nas-tabchiche
feat: workshop 4
ef0ffdd
@Mohamed-Hacene @nas-tabchiche
chore: run format
4db8027
@Mohamed-Hacene @nas-tabchiche
feat: add likelihood endpoint
0f13405
@Mohamed-Hacene @nas-tabchiche
chore: format
30308a2
@nas-tabchiche
Serialize likelihood display
c5752c9
@nas-tabchiche
Internationalize attack paths
ab748f5
@nas-tabchiche
Treat likelihood as a number in forms
fd2f719
@nas-tabchiche
Make threats optional in operational scenario schema
ee87bf0
@nas-tabchiche
Workshop 4 (intuitem#1136)
0a3ea3f
@Mohamed-Hacene
Chore/remove unused props (intuitem#1167)
8bee503
@ab-smith @eric-intuitem
Convert Disaster Recovery Objectives units (intuitem#1168)
c496f1b 
Co-authored-by: eric-intuitem <[email protected]>
@eric-intuitem
Fix language issue for mails (intuitem#1169)
2bad133
@fastlorenzo
Make email comparison for SAML case insensitive
154fe90 
Signed-off-by: Lorenzo Bernardi <[email protected]>
@eric-intuitem
Copy link
Collaborator

eric-intuitem commented Dec 11, 2024 •
edited
Loading

LGTM, but we need to adapt functional tests. @nas-tabchiche ?

@ab-smith
Copy link
Contributor

we will merge it after the Ebios RM sprint and fix the test on our side before releasing

@fastlorenzo
Copy link
Contributor Author

we will merge it after the Ebios RM sprint and fix the test on our side before releasing

Thanks, no worries, now that we know the current behavior we've fixed it in the IDP by forcing lowercase email conversion

@Mohamed-Hacene Mohamed-Hacene mentioned this pull request Feb 13, 2025
Merged
@nas-tabchiche nas-tabchiche changed the title Make email comparison for SAML case insensitive fix: make email comparison for SAML case insensitive Feb 13, 2025
@nas-tabchiche
Copy link
Contributor

Hi @fastlorenzo, we just merged #1498 which should make functional tests pass on this PR. I can't manually re-run the tests (maybe PR is too old). I'm closing this and re-opening to force CI to run.

@nas-tabchiche nas-tabchiche reopened this Feb 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fastlorenzo @eric-intuitem @ab-smith @nas-tabchiche @Mohamed-Hacene @monsieurswag @QuiverX41