Portfolio refactor #715
Portfolio refactor #715
Conversation
|
move interface from types to store/consts |
|
|
|
|
|
logic for that styles types is overcomplicated. just remove it and create styles in separate makeStyles object or separate file |
the same for this |
|
please review the code once again, and it's better to move child components to separate files. to not keep a few in one. like |
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the portfolio components by updating style hooks, import paths, and component structures while removing legacy code.
- Updated style hooks and import paths for skeletal components
- Replaced inline EmptyState with a dedicated component and updated associated types
- Removed unused code from the OverviewYourPositions module
Reviewed Changes
Copilot reviewed 65 out of 65 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/Portfolio/Overview/Overview/skeletons/styles.ts | Reordered imports and added definitions for the desktop skeleton styles |
| src/components/Portfolio/Overview/Overview/skeletons/MobileOverviewSkeleton.tsx | Updated import path for MobileOverviewSkeleton styles |
| src/components/Portfolio/Overview/Overview/skeletons/LegendSkeleton.tsx | Updated import path for LegendSkeleton styles |
| src/components/Portfolio/Overview/Overview/Overview.tsx | Refactored component by adjusting imports, updating types for poolAssets, and replacing inline EmptyState |
| src/components/Portfolio/Overview/Overview/EmptyState/styles.ts & EmptyState/EmptyState.tsx | Added dedicated styling and component for the EmptyState |
| src/components/Portfolio/Overview/MobileOverview/MobileOverview.tsx | Corrected import order for MobileOverviewSkeleton |
| src/components/Portfolio/Overview/LegendOverview/LegendOverview.tsx | Added a key attribute for list items rendering |
| src/components/OverviewYourPositions/* | Removed legacy and unused code |
Comments suppressed due to low confidence (2)
src/components/Portfolio/Overview/Overview/Overview.tsx:29
- Ensure that the new IPositionItem type contains all the necessary fields expected by the Overview component and its children to avoid potential runtime issues.
poolAssets: IPositionItem[]
src/components/Portfolio/Overview/LegendOverview/LegendOverview.tsx:57
- Confirm that the 'token' property used for the key is guaranteed to be unique for each position to prevent potential duplicate key issues during list rendering.
<Grid key={position.token} item container className={classes.tokenRow}>
|
This pull request has been deployed to Vercel.
|
No description provided.