Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: upgrade to v12 #607

Merged
merged 3 commits into from
Jul 16, 2024
Merged

init: upgrade to v12 #607

merged 3 commits into from
Jul 16, 2024

Conversation

utnapischtim
Copy link
Contributor

  • init: upgrade to v12

@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch from 39c788b to 8e491ca Compare March 11, 2024 09:41
@utnapischtim
Copy link
Contributor Author

connected to inveniosoftware/invenio-app-rdm#2609

@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch 3 times, most recently from f620450 to ca71475 Compare March 11, 2024 10:19
@utnapischtim utnapischtim marked this pull request as draft March 11, 2024 11:22
@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch from 5f5558e to 7331222 Compare March 29, 2024 09:39
Samk13
Samk13 reviewed Apr 3, 2024
View reviewed changes
docs/releases/upgrading/upgrade-v12.0.md
### New configuration variables

```bash
COMMUNITIES_IDENTITIES_CACHE_REDIS_URL = "URI_TO_REDIS"
Copy link
Member

@Samk13 Samk13 Apr 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Provide a clear default value that works as default on local setup e.g., "redis://cache:6379/4" and mention that users should replace cache with their own Redis URI for a seamless copy-paste experience.

@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch 2 times, most recently from 20debec to beb51e0 Compare May 2, 2024 08:23
@kpsherva kpsherva marked this pull request as ready for review June 10, 2024 12:04
@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch from beb51e0 to b574487 Compare June 10, 2024 12:22
@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch 4 times, most recently from 09c21bf to a724be0 Compare June 20, 2024 21:31
@utnapischtim utnapischtim mentioned this pull request Jun 24, 2024
Closed
@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch from a724be0 to 1bd176d Compare July 9, 2024 19:20
tmorrell
tmorrell approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mostly some organizational changes around the reindexing parts.

docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Show resolved Hide resolved
max-moser
max-moser reviewed Jul 10, 2024
View reviewed changes
docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Outdated
```

##### Step 4
install InvenioRDM v12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
install InvenioRDM v12
install InvenioRDM v12:

docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
docs/releases/upgrading/upgrade-v12.0.md Outdated Show resolved Hide resolved
@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch from e6e6d14 to ae5333f Compare July 16, 2024 19:08
@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch from ae5333f to 48d0c45 Compare July 16, 2024 19:11
@utnapischtim
global: update workflows/tests.yml
e111e2b
@utnapischtim
fix: broken ci
1636fe1 
* remove dead links

* readd landing_page.md
@utnapischtim utnapischtim force-pushed the add-migration-v11-v12-steps branch from 4717e97 to 1636fe1 Compare July 16, 2024 20:55
@utnapischtim utnapischtim merged commit eae2b08 into inveniosoftware:dev Jul 16, 2024
1 check passed
@utnapischtim utnapischtim deleted the add-migration-v11-v12-steps branch July 16, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samk13 Samk13 Samk13 left review comments

@tmorrell tmorrell tmorrell approved these changes

@carlinmack carlinmack carlinmack left review comments

@max-moser max-moser max-moser left review comments

Assignees

@utnapischtim utnapischtim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@utnapischtim @max-moser @carlinmack @tmorrell @Samk13