invenio: better secret key and salts management #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egabancho
force-pushed
the
better-secrets
branch
from
45e748b to
ba16db7
Compare
lindhe
requested changes
Dec 17, 2024
* Adds missing salts to harden security. * Deprecates plain keys and forces to use secrets for them. * Automatically generates secret key and salts if no secret is provided.
egabancho
force-pushed
the
better-secrets
branch
from
ba16db7 to
3a80c40
Compare
lindhe
reviewed
Dec 21, 2024
|
|
||
| {{- end }} | ||
|
|
||
| {{- if .Values.invenio.existing_secret}} |
There was a problem hiding this comment.
Suggested change
| {{- if .Values.invenio.existing_secret}} | |
| {{- if .Values.invenio.existing_secret }} |
lindhe
reviewed
Dec 21, 2024
| */}} | ||
| {{- define "invenio.secretName" -}} | ||
| {{- if .Values.invenio.existingSecret -}} | ||
| {{- print (tpl .Values.invenio.existingSecret .) -}} |
There was a problem hiding this comment.
Isn't the print statement redundant?
|
I've posted some final comments. After they are fixed I'll approve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing salts to harden security.
Deprecates plain keys and forces to use secrets for them.
Automatically generates secret key and salts if no secret is provided.