Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invenio: merge base config and extraConfig #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egabancho
Copy link
Member

@egabancho egabancho commented Dec 16, 2024


Without any extra variable or overwrite

invenio:
  hostname: foo
  secret_key: foo
  security_login_salt: foo
  csrf_secret_salt: foo
postgresql:
  auth:
    password: foo
rabbitmq:
  enabled: true
  auth:
    password: foo
$ helm template -f values.yaml  ./charts/invenio  -s templates/invenio-configmap.yaml
---
# Source: invenio/templates/invenio-configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: invenio-config
  labels:
    helm.sh/chart: invenio-0.3.0
    app.kubernetes.io/name: invenio
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "v12.0.0-beta.1.3"
    app.kubernetes.io/managed-by: Helm
data:
  INVENIO_ACCOUNTS_SESSION_REDIS_URL: redis://release-name-redis-master:6379/1
  INVENIO_APP_ALLOWED_HOSTS: '["foo"]'
  INVENIO_CACHE_REDIS_HOST: release-name-redis-master
  INVENIO_CACHE_REDIS_URL: redis://release-name-redis-master:6379/0
  INVENIO_CELERY_RESULT_BACKEND: redis://release-name-redis-master:6379/2
  INVENIO_COMMUNITIES_IDENTITIES_CACHE_REDIS_URL: redis://release-name-redis-master:6379/4
  INVENIO_DATACITE_ENABLED: "False"
  INVENIO_IIIF_CACHE_REDIS_URL: redis://release-name-redis-master:6379/0
  INVENIO_LOGGING_CONSOLE_LEVEL: WARNING
  INVENIO_RATELIMIT_STORAGE_URI: redis://release-name-redis-master:6379/3
  INVENIO_SEARCH_HOSTS: '[{''host'': ''release-name-opensearch''}]'
  INVENIO_SITE_API_URL: https://foo/api
  INVENIO_SITE_HOSTNAME: foo
  INVENIO_SITE_UI_URL: https://foo

With extraConfig and overwrite

invenio:
  hostname: foo
  secret_key: foo
  security_login_salt: foo
  csrf_secret_salt: foo
  extraConfig:
    INVENIO_APP_ALLOWED_HOSTS: '["definitely not foo "]'
postgresql:
  auth:
    password: foo
rabbitmq:
  enabled: true
  auth:
    password: foo
helm template -f values.yaml  ./charts/invenio  -s templates/invenio-configmap.yaml
---
# Source: invenio/templates/invenio-configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: invenio-config
  labels:
    helm.sh/chart: invenio-0.3.0
    app.kubernetes.io/name: invenio
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "v12.0.0-beta.1.3"
    app.kubernetes.io/managed-by: Helm
data:
  INVENIO_ACCOUNTS_SESSION_REDIS_URL: redis://release-name-redis-master:6379/1
  INVENIO_APP_ALLOWED_HOSTS: '["definitely not foo "]'
  INVENIO_CACHE_REDIS_HOST: release-name-redis-master
  INVENIO_CACHE_REDIS_URL: redis://release-name-redis-master:6379/0
  INVENIO_CELERY_RESULT_BACKEND: redis://release-name-redis-master:6379/2
  INVENIO_COMMUNITIES_IDENTITIES_CACHE_REDIS_URL: redis://release-name-redis-master:6379/4
  INVENIO_DATACITE_ENABLED: "False"
  INVENIO_IIIF_CACHE_REDIS_URL: redis://release-name-redis-master:6379/0
  INVENIO_LOGGING_CONSOLE_LEVEL: WARNING
  INVENIO_RATELIMIT_STORAGE_URI: redis://release-name-redis-master:6379/3
  INVENIO_SEARCH_HOSTS: '[{''host'': ''release-name-opensearch''}]'
  INVENIO_SITE_API_URL: https://foo/api
  INVENIO_SITE_HOSTNAME: foo
  INVENIO_SITE_UI_URL: https://foo

@egabancho egabancho requested a review from lindhe December 16, 2024 21:02
@lindhe
Copy link
Contributor

lindhe commented Dec 17, 2024

Sounds like two different changes in the same PR here? Can we have them in separate PRs, please?

@egabancho
Copy link
Member Author

Do you mean the checksum thingy?

@lindhe
Copy link
Contributor

lindhe commented Dec 17, 2024

Yes

@egabancho
Copy link
Member Author

Would it be ok for you if I put it on a different commit here? I won't have the time now to go over all the ConfigMaps/Secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants