communityItem: add detailUrl #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrcastro2
commented
Sep 21, 2023
jrcastro2
commented
- closes https://github.com/zenodo/rdm-project/issues/171
kpsherva
reviewed
Sep 21, 2023
| @@ -36,7 +37,7 @@ export const CommunityCompactItemMobile = ({ | |||
|
|
|||
| <div className="flex align-items-center rel-mb-1"> | |||
| <a | |||
| href={links.self_html} | |||
| href={detailUrl || links.self_html} | |||
There was a problem hiding this comment.
minor: if both are provided it will evaluate to true if I am not mistaken
There was a problem hiding this comment.
Based on the docs we should be safe. If detailUrl can be converted to true it will return that value, otherwise it will check for links.self_html
kpsherva
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.