Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pass community_ui dict instead of community object #1230

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

0einstein0
Copy link
Member

@0einstein0 0einstein0 commented Oct 16, 2024

❤️ Thank you for your contribution!

Description

Use community_ui dict instead of community object in button_to_request_membership macro

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@ptamarit
Copy link
Member

Sorry, I missed this one and created a similar fix in #1239

{# TODO: Add relation_to_community for other flows #}
<div
id="request-membership-app"
data-community='{{ community | tojson }}'
data-community="{{ community }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just pass the UI serialized community and it works (tested):

Suggested change
data-community="{{ community }}"
data-community="{{ community_ui | tojson }}"

@0einstein0 0einstein0 changed the title ui: fix null error for rendering RequestMembershipButton refactor: pass community_ui dict instead of community object Oct 23, 2024
@0einstein0 0einstein0 removed their assignment Oct 30, 2024
@ntarocco ntarocco merged commit 9909924 into inveniosoftware:master Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants