Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warnings from marshmallow #214

Conversation

utnapischtim
Copy link
Contributor

@utnapischtim utnapischtim commented Feb 9, 2022

This PR removes the RemovedInMarshmallow4Warning warning by updating the code to the new interface of marshmallow.Field.

It was necessary to wrap parameters (load_from, data_key, dump_to) into a dictionary to give to the parameter metadata.

@utnapischtim utnapischtim force-pushed the remove-deprecation-warnings-from-marshmallow branch from 3d9975f to 058578f Compare February 9, 2022 09:27
@fenekku
Copy link

fenekku commented Feb 17, 2022

Related to inveniosoftware/invenio-app-rdm#1112

@rekt-hard
Copy link
Contributor

rekt-hard commented Feb 21, 2022

LGTM. locally tests pass after #206 has been integrated and this branch has been rebased

@rekt-hard rekt-hard removed their assignment Feb 21, 2022
@lnielsen
Copy link
Member

@utnapischtim or @rekt-hard: Do you mind rebasing the PR so we can merge.

@rekt-hard rekt-hard self-assigned this Mar 1, 2022
utnapischtim and others added 2 commits March 1, 2022 08:22
the updated code remove the RemovedInMarshmallow4Warning warning from
marshmallow.field
@rekt-hard rekt-hard force-pushed the remove-deprecation-warnings-from-marshmallow branch from 7b74172 to 04826dc Compare March 1, 2022 07:28
@rekt-hard rekt-hard removed their assignment Mar 1, 2022
@lnielsen lnielsen merged commit fca4638 into inveniosoftware:master Mar 1, 2022
@utnapischtim utnapischtim deleted the remove-deprecation-warnings-from-marshmallow branch March 2, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants