global: fix tests from pallets family upgrade #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppanero
force-pushed
the
build-fix
branch
3 times, most recently
from
64ead48 to
2b0869b
Compare
Co-authored-by: Zacharias Zacharodimos <[email protected]>
ppanero
force-pushed
the
build-fix
branch
4 times, most recently
from
c082d8d to
3f8c458
Compare
ppanero
commented
May 18, 2022
| @@ -363,7 +362,6 @@ def account_setup(remote, token, resp): | |||
| resource = get_resource(remote, resp) | |||
|
|
|||
| with db.session.begin_nested(): | |||
| person_id = resource.get("cern_person_id") | |||
There was a problem hiding this comment.
this is interesting, we have person_id in ILS, not sure now how it gets there
There was a problem hiding this comment.
🤷♂️ I just see that the person_id is extracted and never used hehe
ppanero
force-pushed
the
build-fix
branch
3 times, most recently
from
d8e77f2 to
1d4d831
Compare
kpsherva
reviewed
May 18, 2022
kpsherva
reviewed
May 18, 2022
kpsherva
reviewed
May 18, 2022
Co-authored-by: Zacharias Zacharodimos <[email protected]>
kpsherva
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauth.mov
Important info
All redirects are now relative, since Flask/Werkzeug 2.1.0. According to the issue it was tested in all the major browsers and CLIs and they do follow redirects properly.
In order to undo it (i.e. allow external redirects) we would need to change this configuration value. An example test in werkzeug is this