Fix conflicting versions of uritemplate library #324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
This pull request fixes issue #299 - conflicting versions of the uritemplate library. Invenio sources in general use the
uritemplate
library, but this module uses theuritemplate-py
library. Both of the libraries provide the same top-leveluritemplate
python module and the one used depends on the installation order.In the pull request, the
uritemplate-py
library was replaced withuritemplate
.Note: it seems that invenio-theme 3.0.0 does not include
flask-breadcrumbs
anymore and this library depends on that.flask-breadcrumbs
were added to test dependencies, not sure if it is correct.Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: