global: replace cchardet by charset_normalizer #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks like a better path forward. charset-normalizer seems like a more developed project and appears to be a much more efficient library. It's also MIT licensed, so should be a good fit. |
ntarocco
approved these changes
Dec 1, 2023
utnapischtim
force-pushed
the
fix-cchardet-by-charset-normalizer
branch
2 times, most recently
from
7c3caa4
to
7e4b869
Compare
utnapischtim
force-pushed
the
fix-cchardet-by-charset-normalizer
branch
from
7e4b869
to
9ef0c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR would be a plan B to #175.