video/audio: add videojs previewer for a/v files #194
Conversation
fenekku
force-pushed
the
7_video_audio_player_videojs
branch
from
c1ab629
to
bf756d4
Compare
This makes them available by default in any invenio-app-rdm backed instance. :warning: depends on inveniosoftware/invenio-previewer#194 being merged and released (i.e. wait for that to confirm dependency versioning too)
invenio_previewer/assets/semantic-ui/js/invenio_previewer/videojs.js
Outdated
Show resolved
Hide resolved
setup.cfg
Outdated
| @@ -28,7 +29,7 @@ python_requires = >=3.7 | |||
| zip_safe = False | |||
| install_requires = | |||
| charset_normalizer>=3.3.2 | |||
| invenio-assets>=1.2.7 | |||
| invenio-assets>=1.2.7,!=3.0.1 | |||
| invenio-base>=1.2.10 | |||
There was a problem hiding this comment.
The exclusion of invenio-assets is a short-term fix. It's important to investigate the root cause of the errors with this version and address them for future compatibility.
There was a problem hiding this comment.
The problem has to do with the improper inclusion of tinymce in invenio-assets 3.0.1 . The issue is known: https://discord.com/channels/692989811736182844/1035104382519365712/1186299141257691167 and any fix would imply a new version, so I think it's reasonable to skip it. I don't know if discord links are very permanent / would make sense to be added though.
There was a problem hiding this comment.
Maybe @kpsherva has a better say about this.
There was a problem hiding this comment.
I think this has been fixed in v3.0.2
| } | ||
|
|
||
| body { | ||
| justify-content: center; |
There was a problem hiding this comment.
This could lead to unexpected global style changes no?
There was a problem hiding this comment.
Only if the built css from audio_videojs.scss (this file) is placed in a "global" (or at least not in the only template it is placed in right now) would it potentially cause issues.
The previewer endpoint returns an HTML page that is rendered inside an iframe on the details page. So its style is always well prevented from affecting wider styles. Other previewers (e.g., the pdf one) take advantage of this to really customize the style to what they need.
|
Excellent contribution, much appreciated! 🚀 |
invenio_previewer/webpack.py
Outdated
| @@ -72,6 +73,9 @@ | |||
| "bottom_css": "./scss/invenio_previewer/bottom.scss", | |||
| "simple_image_css": "./scss/invenio_previewer/simple_image.scss", | |||
| "txt_css": "./scss/invenio_previewer/txt.scss", | |||
| "videojs_js": "./js/invenio_previewer/videojs.js", # shared for audio and video # noqa | |||
There was a problem hiding this comment.
I think here you can point directly to the node_modules/video.js module
|
Tested with nginx server, with Firefox on Ubuntu client. Works well enough. Important thing is to have a fronting server like nginx that can respond to range request (mostly for video). I didn't have to make other nginx config adjustments (other than already done X-Accel-Redirect configuration which allows file serving by nginx in the first place). |
setup.cfg
Outdated
| @@ -28,7 +29,7 @@ python_requires = >=3.7 | |||
| zip_safe = False | |||
| install_requires = | |||
| charset_normalizer>=3.3.2 | |||
| invenio-assets>=1.2.7 | |||
| invenio-assets>=1.2.7,!=3.0.1 | |||
| invenio-base>=1.2.10 | |||
There was a problem hiding this comment.
I think this has been fixed in v3.0.2
fenekku
force-pushed
the
7_video_audio_player_videojs
branch
from
008d1d5
to
6414db8
Compare
|
Rebased. I don't have the repo rights to merge this one though. @lnielsen or someone else can do it now. |
This makes them available by default in any invenio-app-rdm backed instance. :warning: depends on inveniosoftware/invenio-previewer#194 being merged and released (i.e. wait for that to confirm dependency versioning too)
This makes them available by default in any invenio-app-rdm backed instance. :warning: depends on inveniosoftware/invenio-previewer#194 being merged and released (i.e. wait for that to confirm dependency versioning too)
Screenshots
Audio previewer
Initial Video
Paused Video
Notes