feature: add OAI-PMH API #891
Conversation
rekt-hard
force-pushed
the
oaiserver-service
branch
2 times, most recently
from
05d8389 to
b643d00
Compare
feature: implement search fix: pass correct action to require_permission
test: add tests for OAI API
fix marshmallow deprecation warnings
rekt-hard
force-pushed
the
oaiserver-service
branch
from
b643d00 to
e9fa14b
Compare
|
|
||
| """Result items for OAI-PMH services.""" | ||
|
|
||
| from invenio_records_resources.pagination import Pagination |
There was a problem hiding this comment.
Comment: Not something to fix now for this PR, but I think we need to move some of this code to Records-Resources, and see how we can make it more reusable. I've seen it slightly duplicated many places with minor modifications. Again, this is more a comment for myself :-)
| @@ -0,0 +1,232 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Minor: Extra tests I'd like to see:
- It should not be possible to edit a managed set.
- Try with bogus search patterns, very long strings etc. (try to break it a bit more 💣 😀 )
There was a problem hiding this comment.
-
Managed sets are not implemented yet, as this has not been discussed properly afaik (adding/removing records manually, managed flag not present)
-
Since the indexing happens automatically after inserting the set in the db through signals, the only way to check if the
search_patternis valid or not is to try indexing before (and then it gets reindexed again afterwards).- global: disable signals invenio-oaiserver#215
- should probably revisit https://github.com/inveniosoftware/invenio-oaiserver/blob/725f80056f05fefbfcc90e0994694230f38fbe9d/invenio_oaiserver/percolator.py#L75-L114
- add index as a parameter to only create percolator document once
- validate search pattern and raise an error if it is not valid
depends on inveniosoftware/invenio-oaiserver#206
Adds API for OAI-PMH sets