-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datastreams + names vocabulary + tasks rest api #127
Conversation
Co-authored-by: Dimitris Frangiadakis <[email protected]>
@@ -62,6 +62,8 @@ | |||
install_requires = [ | |||
"invenio-records-resources>=0.18.2,<0.19.0", | |||
"invenio-i18n>=1.3.1", | |||
"lxml>=4.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requires v4.5.0 or higher, otherwise it fails to install. see https://github.com/inveniosoftware/invenio-vocabularies/actions/runs/1687543630
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review
I would not block merging for any of them, I would open issues if you agree @slint.
- Some commits are from 2022, but copyright still points to 2021. I will take it into account from now on but I do not think is needed to be cherry-picking and fixing the tree for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor things I came across. Otherwise LGTM 🪨 🇪🇹
closes inveniosoftware/invenio-rdm-records#868
Integration of datastreams, names vocabulary and PoC tasks REST API. This PR contains a big amount of work, commits are as isolated as possible, I think there is no need to squash.
Datastreams
As defined in the RFC
TarReader
,YamlReader
,SimpleHTTPReader
XMLTransformer
YamlWriter
,ServiceWriter
Names vocabulary
As defined in the RFC
OrcidHTTPReader
OrcidXMLTransformer
NamesServiceWriter
Tasks REST API
/tasks
endpoint to launch (POST) tasks