Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastreams + names vocabulary + tasks rest api #127

Merged
merged 21 commits into from
Jan 19, 2022
Merged

datastreams + names vocabulary + tasks rest api #127

merged 21 commits into from
Jan 19, 2022

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Jan 12, 2022

closes inveniosoftware/invenio-rdm-records#868

Integration of datastreams, names vocabulary and PoC tasks REST API. This PR contains a big amount of work, commits are as isolated as possible, I think there is no need to squash.

Datastreams

As defined in the RFC

  • Readers: TarReader, YamlReader, SimpleHTTPReader
  • Transformer: XMLTransformer
  • Writer: YamlWriter, ServiceWriter
  • BaseDatastream
  • BaseFixture
  • CLI: import, convert and delete (a single entry)

Names vocabulary

As defined in the RFC

  • Reader: OrcidHTTPReader
  • Transformers: OrcidXMLTransformer
  • Writer: NamesServiceWriter

Tasks REST API

  • /tasks endpoint to launch (POST) tasks

@ppanero ppanero requested a review from slint January 12, 2022 12:21
@@ -62,6 +62,8 @@
install_requires = [
"invenio-records-resources>=0.18.2,<0.19.0",
"invenio-i18n>=1.3.1",
"lxml>=4.5.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires v4.5.0 or higher, otherwise it fails to install. see https://github.com/inveniosoftware/invenio-vocabularies/actions/runs/1687543630

@ppanero ppanero changed the title [blocked] datastreams + names vocabulary datastreams + names vocabulary Jan 18, 2022
Copy link
Member Author

@ppanero ppanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

I would not block merging for any of them, I would open issues if you agree @slint.

  • Some commits are from 2022, but copyright still points to 2021. I will take it into account from now on but I do not think is needed to be cherry-picking and fixing the tree for this.

@ppanero ppanero changed the title datastreams + names vocabulary datastreams + names vocabulary + tasks rest api Jan 18, 2022
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things I came across. Otherwise LGTM 🪨 🇪🇹

@ppanero ppanero merged commit c8370f2 into master Jan 19, 2022
@ppanero ppanero deleted the names branch January 19, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vocabularies: merge names into master
3 participants