contrib: names: update field boosts and mapping #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
reviewed
Jul 24, 2024
jrcastro2
reviewed
Jul 24, 2024
invenio_vocabularies/contrib/names/jsonschemas/names/name-v2.0.0.json
Outdated
Show resolved
Hide resolved
invenio_vocabularies/contrib/names/mappings/os-v1/names/name-v2.0.0.json
Show resolved
Hide resolved
sakshamarora1
force-pushed
the
fix/names_vocab
branch
2 times, most recently
from
ac52df8
to
557337c
Compare
|
can you add a test of the suggest endpoint like https://github.com/inveniosoftware/invenio-vocabularies/blob/master/tests/contrib/funders/test_funders_resource.py#L116 :) |
sakshamarora1
force-pushed
the
fix/names_vocab
branch
from
c8cd61d
to
9ab62f2
Compare
sakshamarora1
force-pushed
the
fix/names_vocab
branch
from
9ab62f2
to
64f876b
Compare
jrcastro2
reviewed
Jul 30, 2024
|
ES tests are failing |
|
@jrcastro2 ES tests are removed in #372 😅 |
kpsherva
reviewed
Aug 1, 2024
invenio_vocabularies/contrib/names/mappings/os-v1/names/name-v2.0.0.json
Outdated
Show resolved
Hide resolved
kpsherva
reviewed
Aug 1, 2024
slint
reviewed
Aug 7, 2024
invenio_vocabularies/contrib/names/mappings/os-v2/names/name-v2.0.0.json
Outdated
Show resolved
Hide resolved
invenio_vocabularies/contrib/names/mappings/os-v2/names/name-v2.0.0.json
Outdated
Show resolved
Hide resolved
slint
reviewed
Aug 13, 2024
sakshamarora1
force-pushed
the
fix/names_vocab
branch
from
b4204d1
to
e4a27b2
Compare
zzacharo
reviewed
Aug 14, 2024
There was a problem hiding this comment.
@sakshamarora1 there is only one comment on this from @slint. Otherwise, it seems good to go!
ntarocco
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: inveniosoftware/invenio-app-rdm#2756
The names in the database and index are inverted, therefore the suggest API first tries to search on the last name and prioritizes that due to how edge ngram works for the suggest API.
This solution add suggest API for given name for better results.
ATTENTION
tests fail due to #372, to be rebased and merged after #372