-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate subjects in awards datastream #402
Integrate subjects in awards datastream #402
Conversation
9901019
to
881d20a
Compare
7bd9767
to
66c1c6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with @anikachurilova
Thanks a lot, that was a lot of work! 🚀
Small suggestion for future developments: if possible, split in multiple PRs so it's easier to review
91aaab1
to
1512b3f
Compare
7319a01
to
85c94a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have an extra approval, since this was reviewed by multiple people.
85c94a8
to
9b0e908
Compare
db6f8bd
to
9b0e908
Compare
9b0e908
to
efe9177
Compare
❤️ Thank you for your contribution!
Description
Closes Issue #401
Associated Issue: #382
Based on top of: #399
db
api/awards
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: