Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate subjects in awards datastream #402

Merged
merged 11 commits into from
Oct 3, 2024

Conversation

0einstein0
Copy link
Member

@0einstein0 0einstein0 commented Sep 16, 2024

❤️ Thank you for your contribution!

Description

Closes Issue #401
Associated Issue: #382
Based on top of: #399

db

{
  "title": {
    "en": "Exploring the PFAS alternatives-induced immunotoxicity and impact on intercellular communication."
  },
  "funder": {
    "id": "00k4n6c32"
  },
  "number": "101153260",
  "$schema": "local://awards/award-v1.0.0.json",
  "acronym": "EPIC",
  "subjects": [
    {
      "id": "euroscivoc:313"
    },
    {
      "id": "euroscivoc:155"
    }
  ],
  "identifiers": [
    {
      "scheme": "url",
      "identifier": "https://cordis.europa.eu/projects/101153260"
    }
  ],
  "organizations": [
    {
      "id": "999880657",
      "scheme": "pic",
      "organization": "Masarykova univerzita"
    }
  ]
}

api/awards

{
    "id": "00k4n6c32::101153260",
    ...
    ...
    ...
    "title": {
        "en": "Exploring the PFAS alternatives-induced immunotoxicity and impact on intercellular communication."
    },
    "identifiers": [
        {
            "identifier": "https://cordis.europa.eu/projects/101153260",
            "scheme": "url"
        }
    ],
    "number": "101153260",
    "funder": {
        "id": "00k4n6c32",
        "name": "European Commission"
    },
    "acronym": "EPIC",
    "subjects": [
        {
            "id": "euroscivoc:313",
            "subject": "Cell biology",
            "scheme": "EuroSciVoc",
            "props": {
                "parents": "euroscivoc:23,euroscivoc:49"
            },
            "identifiers": [
                {
                    "identifier": "http://data.europa.eu/8mn/euroscivoc/a9aa37ce-d8d5-4d68-9123-ffbced0aed12",
                    "scheme": "url"
                }
            ]
        },
        {
            "id": "euroscivoc:155",
            "subject": "Immunology",
            "scheme": "EuroSciVoc",
            "props": {
                "parents": "euroscivoc:21,euroscivoc:35"
            },
            "identifiers": [
                {
                    "identifier": "http://data.europa.eu/8mn/euroscivoc/7a3cf568-46ba-4840-be8f-f22fc030139f",
                    "scheme": "url"
                }
            ]
        }
    ],
    "organizations": [
        {
            "id": "999880657",
            "organization": "Masarykova univerzita",
            "scheme": "pic"
        }
    ]
}

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@0einstein0 0einstein0 linked an issue Sep 16, 2024 that may be closed by this pull request
4 tasks
@0einstein0 0einstein0 force-pushed the Awards-Datastream branch 4 times, most recently from 9901019 to 881d20a Compare September 20, 2024 07:56
@alejandromumo alejandromumo changed the title Awards datastream Integrate subjects in awards datastream Sep 26, 2024
Copy link
Member

@alejandromumo alejandromumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @anikachurilova

Thanks a lot, that was a lot of work! 🚀

Small suggestion for future developments: if possible, split in multiple PRs so it's easier to review

invenio_vocabularies/cli.py Show resolved Hide resolved
invenio_vocabularies/config.py Show resolved Hide resolved
invenio_vocabularies/datastreams/readers.py Show resolved Hide resolved
invenio_vocabularies/datastreams/writers.py Outdated Show resolved Hide resolved
invenio_vocabularies/factories.py Outdated Show resolved Hide resolved
tests/contrib/affiliations/conftest.py Show resolved Hide resolved
@0einstein0 0einstein0 force-pushed the Awards-Datastream branch 4 times, most recently from 91aaab1 to 1512b3f Compare September 30, 2024 11:34
@0einstein0 0einstein0 force-pushed the Awards-Datastream branch 2 times, most recently from 7319a01 to 85c94a8 Compare October 2, 2024 07:14
Copy link
Member

@alejandromumo alejandromumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have an extra approval, since this was reviewed by multiple people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate subjects in awards datastream
5 participants