Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename patched filters so the normalizer uses the default ones #409

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Rename patched filters so the normalizer uses the default ones #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0af25b
rename patched filters so the normalizer uses the default ones
wgresshoff Oct 8, 2024
513e593
changed filter names to comply with existing names
wgresshoff Oct 8, 2024
6cbca0b
changed filter names to comply with existing names
wgresshoff Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions invenio_vocabularies/contrib/funders/mappings/os-v1/funders/funder-v2.0.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"type": "custom",
"char_filter": ["strip_special_chars"],
"filter": [
"lowercase",
"asciifolding",
"lowercasepreserveoriginal",
Copy link
Contributor

@kpsherva kpsherva Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wgresshoff could I ask you to move all the changes to funder-v3.0.0.json files?
in case of breaking changes like these we need to upgrade the version of the mapping, otherwise instance upgrades are complex
so we need to (for both os-v1 and os-v2)

  • copy the mappings to funder-v3.0.0.json
  • move the changes you proposed here to funder-v3.0.0.json file
  • revert funders-v2.0.0.json changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since in practice this doesn't break existing indices created with the old mapping but only affects search behavior/accuracy, I feel we can merge without bumping the mapping version.

This means that for deployment, one needs to either:

  • Do the usual recreation of indices (with downtime)
  • Do a live migration with some special handling since the old and new index name will be the same (only the timestamp suffix changes).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used the recreation of indices with downtime and the missing funders were reindexed without problem.

"asciifoldingpreserveoriginal",
"edgegrams"
]
},
Expand All @@ -24,8 +24,8 @@
"type": "custom",
"char_filter": ["strip_special_chars"],
"filter": [
"lowercase",
"asciifolding"
"lowercasepreserveoriginal",
"asciifoldingpreserveoriginal"
]
}
},
Expand All @@ -40,11 +40,11 @@
}
},
"filter": {
"lowercase": {
"lowercasepreserveoriginal": {
"type": "lowercase",
"preserve_original": true
},
"asciifolding": {
"asciifoldingpreserveoriginal": {
"type": "asciifolding",
"preserve_original": true
},
Expand Down
12 changes: 6 additions & 6 deletions invenio_vocabularies/contrib/funders/mappings/os-v2/funders/funder-v2.0.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"type": "custom",
"char_filter": ["strip_special_chars"],
"filter": [
"lowercase",
"asciifolding",
"lowercasepreserveoriginal",
"asciifoldingpreserveoriginal",
"edgegrams"
]
},
Expand All @@ -24,8 +24,8 @@
"type": "custom",
"char_filter": ["strip_special_chars"],
"filter": [
"lowercase",
"asciifolding"
"lowercasepreserveoriginal",
"asciifoldingpreserveoriginal"
]
}
},
Expand All @@ -40,11 +40,11 @@
}
},
"filter": {
"lowercase": {
"lowercasepreserveoriginal": {
"type": "lowercase",
"preserve_original": true
},
"asciifolding": {
"asciifoldingpreserveoriginal": {
"type": "asciifolding",
"preserve_original": true
},
Expand Down