Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components: add affiliations suggestions display component #255
components: add affiliations suggestions display component #255
Changes from 2 commits
c893900
53a6002
0f2579e
f953a53
4bfeb24
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to fix the tests we need to sort the import of
react-i18next
. In my opinion I think it would be better to shelve introducing i18n to react-invenio-forms and remove it from this PR, rather than introducing the translation mechanism (like so) in this PR.This is the only translation that we would be supporting by importing
react-i18next
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed IRL, we could introduce a prop with a default value to the text without translation. Then, in the places that this component is used we can pass a translatable text as a property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did attempt to change this into a component (as this is currently just a function which returns a list of dictionaries) so we could do this, however it would require changing how it is used which is not simple (as it is expecting a list of dictionaries not a react component)
I need to work on other things so I'm removing this translation and shelving this #6, apologies