Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MFA auth flow #8720

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Dec 18, 2024

Re-adds (simplified) template to render MFA flows.

Closes #8690

@matmair matmair added bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface labels Dec 18, 2024
@matmair matmair added this to the 0.17.1 milestone Dec 18, 2024
@matmair matmair self-assigned this Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 30b4f70
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67634c0c5b86750008f303e9
😎 Deploy Preview https://deploy-preview-8720--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair
Copy link
Member Author

matmair commented Dec 18, 2024

This should work as-is but waiting for feedback from @sur5r before marking ready

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (6634bc5) to head (30b4f70).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8720      +/-   ##
==========================================
- Coverage   85.24%   85.11%   -0.14%     
==========================================
  Files        1175     1175              
  Lines       52424    52530     +106     
  Branches     2075     2075              
==========================================
+ Hits        44691    44709      +18     
- Misses       7226     7314      +88     
  Partials      507      507              
Flag Coverage Δ
backend 86.96% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat added old user interface backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch labels Dec 18, 2024
@matmair matmair marked this pull request as ready for review December 19, 2024 14:51
@matmair
Copy link
Member Author

matmair commented Dec 19, 2024

Got positive feedback in #8690 (comment)
@SchrodingersGat ready for review and merge

@SchrodingersGat SchrodingersGat merged commit aad5575 into inventree:master Dec 19, 2024
32 checks passed
@SchrodingersGat SchrodingersGat deleted the matmair/issue8690 branch December 19, 2024 20:21
Copy link
Contributor

💔 All backports failed

Status Branch Result
0.17.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 8720

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat pushed a commit to SchrodingersGat/InvenTree that referenced this pull request Dec 19, 2024
* Re-add html account base
Fixes inventree#8690

* fix base template
SchrodingersGat added a commit that referenced this pull request Dec 19, 2024
* Re-add html account base
Fixes #8690

* fix base template

Co-authored-by: Matthias Mair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PUI] Login broken with MFA enabled, template missing
2 participants