Now or never #8067
Open
Now or never #8067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value string 'now' for time at the moment of evaluation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow in comparison of date/time fields to compare to the actual time of the moment of execution. 'now' is used as a placeholder for the time at execution.
Impacts
The former behaviour is not modified, but only extended to recognize the string 'now' as a time expression.
The old code in date_before.pm and in date_after.pm already seems to imply that an empty value would have let to use the actual time.
The web gui doesn't allow the empty value and leaving the field empty wouldn't help to make the rules more readable.
Issue
fixes #8066