fix an exception when nt key cache is enabled but no max login attempt was defined #8156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgmsa
commented
May 16, 2024
Comment on lines
+176
to
+179
| if ad_old_password_allowed_period < 0 or ad_old_password_allowed_period > 99999: | ||
| print(f" NT Key cache: 'ad_old_password_allowed_period' ranges from 0..99999, cache disabled.") | ||
| nt_key_cache_enabled = False | ||
| break |
There was a problem hiding this comment.
0 and 99999 are valid ad_old_password_allowed_peroid.
if it's set to 0, no old password will be accepted, changing password will immeidately revoke access of old password.
while 99999 means old password will still valid for 99999 minutes. but no admin will gonna do that in production environment.
|
@stgmsa please backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix an exception when NT key cache is enabled and no max password attempts is defined, parsing old_password_allowed_peroid is ignored issue.
Impacts
fix an exception when NT key cache is enabled and no max password attempts is defined, parsing old_password_allowed_peroid is ignored issue.
without this fix, an specific authentication will fail.
Delete branch after merge
YES
Checklist