Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/security extra message wrapping #8231

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

stgmsa
Copy link
Contributor

@stgmsa stgmsa commented Jul 29, 2024

Description

This fixes issue #8192,
In security event configuration, if admin wish to use a variable in additional email message, it will be ignored during template parsing stage during the config loading stage. This is a fix to avoid this.

Impacts

changed default behavior of using variables in extra message in security event email template.
In the admin UI, admins still use [% variable_name %] to wrap the variable, but in the backend, we use another layer to wrap the variable once more to avoid this to be parsed to null when loading config files.

Issue

fixes #8192

Delete branch after merge

YES

Checklist

  • [yes] Document the feature
  • [no] Add OpenAPI specification
  • [no] Add unit tests
  • [no] Add acceptance tests (TestLink)

Bug Fixes

fixes the issue that a variable is not parsed in extra message in security event's template. #8192

@satkunas satkunas merged commit fc4c1fd into devel Jul 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

built-in variable doesn't show in security events
2 participants