Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http-core package #430

Merged
merged 29 commits into from
Feb 23, 2025
Merged

Add http-core package #430

merged 29 commits into from
Feb 23, 2025

Conversation

Adrianmjim
Copy link
Member

Added

  • Create http-core package
  • Add http-core basic models
  • Add http-core request method decoratos
  • Add http-core controller decorator
  • Add http-core request param decorators
  • Add InversifyHttpAdapter

@Adrianmjim Adrianmjim marked this pull request as draft February 21, 2025 12:48
notaphplover
notaphplover requested changes Feb 22, 2025
View reviewed changes
Copy link
Member

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice! I really like the abstraction. I added some minor details to polish.

packages/http/libraries/core/src/adapter/InversifyHttpAdapter.ts Outdated
case RequestMethodParameterType.NEXT: {
return next;
}
case RequestMethodParameterType.PRINCIPAL: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about this :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functionality returns the user from the request in the current library. We currently do not have an authentication service, which is why it is disabled.

Anyways, if we enable authentication services, do we want to keep this functionality with the same name and usage? I'm not sure.

@Adrianmjim
fix(http-core): fix readme
e0c897e
@Adrianmjim
refactor(http-core): move files to correct folder
46fba89
@Adrianmjim
chore(http-core): add InversifyHttpAdapterError
e244e64
@Adrianmjim
feat(http-core): add basic HttpResponse
434ead4
@Adrianmjim
chore(http-core): add head RequestMethodType
d9c8925
@Adrianmjim
chore(http-core): add inversify as peer dependency
0addb6a
@Adrianmjim
refactor(http-core): refactor InversifyHttpAdapter to simplify reply …
c7c2c41 
…function
@Adrianmjim
Merge branch 'main' of https://github.com/Adrianmjim/inversify-monorepo…
3eeeb42 
… into feat/add-http-support
@Adrianmjim
fix(http-core): fix package index
606138b
@Adrianmjim
refactor(http-core): change decorator method request names
36c0b77
@Adrianmjim
feat(http-core): add head request method decorator
57e914c
@Adrianmjim
refactor(http-core): refactor request method decorators to avoid lint…
654f39c 
… error
@Adrianmjim
feat(http-core): add HttpResponse errors and success
58b6149
@Adrianmjim
chore(http-core): add controller decorator test
5f63478
@Adrianmjim
chore(http-core): add HttpResponse to export index
6834e15
@Adrianmjim
chore(http-core): add controller models
2834134
@Adrianmjim
chore(http-core): refactor InversifyHttpAdapter to use controller models
07b463c
@Adrianmjim
refactor(http-core): refactor RouteParams
7ceaa1b
notaphplover
notaphplover reviewed Feb 23, 2025
View reviewed changes
Copy link
Member

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, let's fix CI issues and I think we can merge

@Adrianmjim Adrianmjim changed the title [WIP] Add http-core package Add http-core package Feb 23, 2025
@Adrianmjim Adrianmjim marked this pull request as ready for review February 23, 2025 13:05
@notaphplover notaphplover merged commit 11dd25d into inversify:main Feb 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notaphplover notaphplover notaphplover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adrianmjim @notaphplover