-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor controller method parameter metadata #437
Refactor controller method parameter metadata #437
Conversation
…actor/controller-method-parameter-metadata
…actor/controller-method-parameter-metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, let's add some additional checks and we can merge it
packages/http/libraries/core/src/http/decorators/RequestParam.ts
Outdated
Show resolved
Hide resolved
packages/http/libraries/core/src/http/decorators/RequestParam.ts
Outdated
Show resolved
Hide resolved
…actor/controller-method-parameter-metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! I saw a casting I believe we should avoid
packages/http/libraries/core/src/http/decorators/RequestParam.ts
Outdated
Show resolved
Hide resolved
…actor/controller-method-parameter-metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Refactor