-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement reversed-filter-group-priority option #702
base: main
Are you sure you want to change the base?
feat: implement reversed-filter-group-priority option #702
Conversation
c5ec3d2
to
aa01c11
Compare
aa01c11
to
eb854ee
Compare
I had a look again and I agree with what it is trying to do, but as I've said before I don't like the complexity of introducing the priority groups. I haven't come up with any other ideas though, do you have any other ideas how this could be handled? |
@spydon, the most obvious and prominent idea in my opinion is to implement filters' prioritization based on the order of their input, however, I foresee this feature will require quite some changes. Alternatively, we could just create a flag (how would we call it?) specifically handling this case to prioritize So, I agree that the priority groups is not the greatest way to solve the case, but I don't see many other ways at the moment how to do that elegantly without much effort/potential to break what is already working. |
That sounds like a great idea! If some filters aren't coming in through flags, but through config, we have to have a way to decide the order between the flags and those ones too right? |
I believe it should be possible. |
Do you want to dig deeper into that option? I think it would be a better solution to the problem. |
I would love to, however as I noted in the PR description it will likely require way more work for which I do not have enough time in the upcoming month or 2, so I'll leave it like this in case someone has time and desire to implement the other approach, otherwise I can get back to it myself sometime later. |
Description
This PR adds a new filtering option that implements the problem/desired behavior described in this issue.
The implementation is backward compatible, so the default filtering behavior should stay as it is.
Ideally, I'd love to have the possibility to prioritize filters based on the order of their input, but it seems to me that would require way more changes, so this is the simpler trade-off solution I have come up with so far.
The alternative approach I ended up implementing in the CI workflow of our big project implies setting the global
MELOS_PACKAGES
scope filter with the values frommelos list --diff=origin/main...HEAD --include-dependents
. The approach is described in https://itnext.io/flutter-selective-ci-checks-2d79ffbd26e5 article. Hopefully, it is helpful for other looking for optimization in their CI pipelines!Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore