fix(android): protect against headlessJS task multiple-invocation #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/notifee~1176 Documentation is deployed and generated using docs.page. |
mikehardy
added
the
pending-merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 32 32
Lines 1727 1727
Branches 556 579 +23
=======================================
Hits 1331 1331
Misses 395 395
Partials 1 1 |
it was possible if multiple tasks came in at once while react-native headlessJS was performing initial react-native startup for the queued events to be invoked multiple times once startup finished this is protected via a couple mechanisms now
mikehardy
force-pushed
the
@mikehardy/headlessjs-prevent-multiple-invoke
branch
from
3bcb106 to
633bf67
Compare
mikehardy
removed
the
pending-merge
|
🎉 This PR is included in version 9.1.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some protection in the headlessJS area against draining the task queue multiple times and/or invoking the same task multiple times - both aimed at preventing the unfortunate possible result of race conditions while draining the task queue of any tasks that came in while react-native startup was happening