Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(expo): update android compileSdk installation guidance #1178

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(expo): update android compileSdk installation guidance #1178

wants to merge 1 commit into from
+1 −1

Conversation

a-eid
Copy link

@a-eid a-eid commented Dec 23, 2024

No description provided.

@docs-page docs.page
Copy link

docs-page bot commented Dec 23, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/notifee~1178

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

mikehardy
mikehardy approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must have missed that one, good catch!
I recognize this appears like a trivial change - and it is really - but we still need you to follow the link to the CLA and handle it before I can merge

Thank you!

@mikehardy mikehardy changed the title Update installation.mdx docs(expo): update android compileSdk installation guidance Dec 23, 2024
@mikehardy mikehardy added pending-merge Waiting on CI or question responses to merge, but otherwise ready blocked: cla-signing needs CLA signed before merge labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees
No one assigned
Labels
blocked: cla-signing needs CLA signed before merge pending-merge Waiting on CI or question responses to merge, but otherwise ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-eid @CLAassistant @mikehardy