Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): bubble action #72

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

helenaford
Copy link
Member

@helenaford helenaford commented Apr 6, 2021

Branches off full-screen-intent p/r. Should be merged after that's released.

Interesting though, it looks like a version bump to androidx.core:*:1.5.0-rc01 is needed. For the bubble to appear (https://developer.android.com/guide/topics/ui/bubbles#when_bubbles_appear), the following needs to be met:

  • The notification uses MessagingStyle, and has a Person added.
  • The notification is from a call to Service.startForeground, has a category of CATEGORY_CALL, and has a Person added.
  • The app is in the foreground when the notification is sent.

To meet the requirement for has a Person added , as far as I can tell, it requires this API NotificationCompact.Builder.addPerson(person) which isn't there on the current stable version. There is NotificationCompact.Builder.addPerson(uri) but it's deprecated.

API design decisions:

  • To call this property a 'bubbleAction' to stick with the current theme that all actions (fullScreenAction, pressAction) have a launchActivity and a mainComponent.

Base automatically changed from @helenaford/full-screen-intent to master April 16, 2021 15:50
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Dec 6, 2022
@github-actions github-actions bot closed this Dec 21, 2022
@fukemy
Copy link

fukemy commented Jul 11, 2023

hi did you solved this problem : #153 (comment)

@8BallBomBom
Copy link

@mikehardy Can we have this opened please?
Would be a good addition if possible to fully integrate.

@mikehardy mikehardy reopened this Oct 3, 2024
@mikehardy
Copy link
Collaborator

No promises but I can give it a look sure. In my experience Helena's work was great so I actually have high hopes

@github-actions github-actions bot removed the Stale label Oct 3, 2024
Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Nov 13, 2024
@github-actions github-actions bot closed this Nov 28, 2024
@mikehardy mikehardy added Keep Open this label avoids the stale bot and removed Stale labels Nov 28, 2024
@mikehardy mikehardy reopened this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Keep Open this label avoids the stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants