-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): bubble action #72
base: main
Are you sure you want to change the base?
Conversation
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
hi did you solved this problem : #153 (comment) |
@mikehardy Can we have this opened please? |
No promises but I can give it a look sure. In my experience Helena's work was great so I actually have high hopes |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Branches off full-screen-intent p/r. Should be merged after that's released.
Interesting though, it looks like a version bump to
androidx.core:*:1.5.0-rc01
is needed. For the bubble to appear (https://developer.android.com/guide/topics/ui/bubbles#when_bubbles_appear), the following needs to be met:To meet the requirement for
has a Person added
, as far as I can tell, it requires this APINotificationCompact.Builder.addPerson(person)
which isn't there on the current stable version. There is NotificationCompact.Builder.addPerson(uri) but it's deprecated.API design decisions:
launchActivity
and amainComponent
.