Skip to content

Commit

Permalink
fix(ios, sdk): constrain transitive dependencies more tightly
Browse files Browse the repository at this point in the history
some were slipping out to 11.4.0 and causing compilation failures
while the majority of the system was still on 11.3.0

we can't set exact versions because some pods don't version while others
do (a previous issue) but we *can* set a max for compatibility reasons
  • Loading branch information
mikehardy committed Oct 22, 2024
1 parent 601e38e commit 12fb715
Show file tree
Hide file tree
Showing 17 changed files with 88 additions and 88 deletions.
6 changes: 3 additions & 3 deletions packages/analytics/RNFBAnalytics.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ Pod::Spec.new do |s|
raise "Firebase/AnalyticsWithoutAdIdSupport requires firebase-ios-sdk 7.11.0 or greater."
end

s.dependency 'Firebase/AnalyticsWithoutAdIdSupport', firebase_sdk_version
s.dependency 'Firebase/AnalyticsWithoutAdIdSupport', "<= #{firebase_sdk_version}"
else
if !defined?($RNFirebaseAnalyticsWithoutAdIdSupport)
Pod::UI.puts "#{s.name}: Using default Firebase/Analytics with Ad Ids. May require App Tracking Transparency. Not allowed for Kids apps."
Pod::UI.puts "#{s.name}: You may set variable `$RNFirebaseAnalyticsWithoutAdIdSupport=true` in Podfile to use analytics without ad ids."
end
s.dependency 'Firebase/Analytics', firebase_sdk_version
s.dependency 'Firebase/Analytics', "<= #{firebase_sdk_version}"

# Special pod for on-device conversion
if defined?($RNFirebaseAnalyticsEnableAdSupport) && ($RNFirebaseAnalyticsEnableAdSupport == true)
Expand All @@ -69,7 +69,7 @@ Pod::Spec.new do |s|
raise "GoogleAppMeasurementOnDeviceConversion requires firebase-ios-sdk 9.0.0 or greater."
end

s.dependency 'GoogleAppMeasurementOnDeviceConversion', firebase_sdk_version
s.dependency 'GoogleAppMeasurementOnDeviceConversion', "<= #{firebase_sdk_version}"
end

if defined?($RNFirebaseAsStaticFramework)
Expand Down
2 changes: 1 addition & 1 deletion packages/app-check/RNFBAppCheck.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/AppCheck', firebase_sdk_version
s.dependency 'Firebase/AppCheck', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/app-distribution/RNFBAppDistribution.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/AppDistribution', firebase_sdk_version
s.dependency 'Firebase/AppDistribution', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/app/RNFBApp.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/CoreOnly', firebase_sdk_version
s.dependency 'Firebase/CoreOnly', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/auth/RNFBAuth.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Auth', firebase_sdk_version
s.dependency 'Firebase/Auth', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
4 changes: 2 additions & 2 deletions packages/crashlytics/RNFBCrashlytics.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Crashlytics', firebase_sdk_version
s.dependency 'FirebaseCoreExtension'
s.dependency 'Firebase/Crashlytics', "<= #{firebase_sdk_version}"
s.dependency 'FirebaseCoreExtension', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/database/RNFBDatabase.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Database', firebase_sdk_version
s.dependency 'Firebase/Database', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/dynamic-links/RNFBDynamicLinks.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/DynamicLinks', firebase_sdk_version
s.dependency 'Firebase/DynamicLinks', "<= #{firebase_sdk_version}"
s.dependency 'GoogleUtilities/AppDelegateSwizzler'

if defined?($RNFirebaseAsStaticFramework)
Expand Down
2 changes: 1 addition & 1 deletion packages/firestore/RNFBFirestore.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Firestore', firebase_sdk_version
s.dependency 'Firebase/Firestore', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/functions/RNFBFunctions.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Functions', firebase_sdk_version
s.dependency 'Firebase/Functions', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/in-app-messaging/RNFBInAppMessaging.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/InAppMessaging', firebase_sdk_version
s.dependency 'Firebase/InAppMessaging', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/installations/RNFBInstallations.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Installations', firebase_sdk_version
s.dependency 'Firebase/Installations', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
4 changes: 2 additions & 2 deletions packages/messaging/RNFBMessaging.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Messaging', firebase_sdk_version
s.dependency 'FirebaseCoreExtension'
s.dependency 'Firebase/Messaging', "<= #{firebase_sdk_version}"
s.dependency 'FirebaseCoreExtension', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/perf/RNFBPerf.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Performance', firebase_sdk_version
s.dependency 'Firebase/Performance', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/remote-config/RNFBRemoteConfig.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/RemoteConfig', firebase_sdk_version
s.dependency 'Firebase/RemoteConfig', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/storage/RNFBStorage.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Storage', firebase_sdk_version
s.dependency 'Firebase/Storage', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
Loading

0 comments on commit 12fb715

Please sign in to comment.