fix(app-check, ios): remove import loop to fix protocol def warning

import loops can apparently be the root cause of protocol definition issues, and if you ensure imports only happen once by chaining correctly then protocol definitions are found correctly and the warning goes away
invertase · Nov 14, 2024 · 789d41b · 789d41b
1 parent e4c57fa
commit 789d41b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckModule.m b/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckModule.m
@@ -16,13 +16,13 @@
  */
 
 #import <Firebase/Firebase.h>
+#import <FirebaseAppCheck/FIRAppCheck.h>
+
 #import <React/RCTUtils.h>
 
 #import "RNFBApp/RNFBSharedUtils.h"
 #import "RNFBAppCheckModule.h"
 
-#import "FirebaseAppCheck/FIRAppCheck.h"
-
 @implementation RNFBAppCheckModule
 #pragma mark -
 #pragma mark Module Setup

diff --git a/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProviderFactory.h b/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProviderFactory.h
@@ -15,7 +15,7 @@
  *
  */
 
-#import <FirebaseAppCheck/FIRAppCheck.h>
+#import "RNFBAppCheckProvider.h"
 
 @interface RNFBAppCheckProviderFactory : NSObject <FIRAppCheckProviderFactory>
 

diff --git a/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProviderFactory.m b/packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProviderFactory.m
@@ -16,10 +16,7 @@
  */
 
 #import "RNFBAppCheckProviderFactory.h"
-#import <Firebase/Firebase.h>
-#import <FirebaseAppCheck/FIRAppCheck.h>
 #import "RNFBApp/RNFBSharedUtils.h"
-#import "RNFBAppCheckProvider.h"
 
 @implementation RNFBAppCheckProviderFactory
-Original file line number
+Diff line change
@@ Expand Up / @@ -15,7 +15,7 @@ @@
      *
      */
-    #import <FirebaseAppCheck/FIRAppCheck.h>
+    #import "RNFBAppCheckProvider.h"
     @interface RNFBAppCheckProviderFactory : NSObject <FIRAppCheckProviderFactory>
@@ Expand Down @@