Skip to content

Commit

Permalink
fix(android, app): fix hot-reload on react-native <= 0.73
Browse files Browse the repository at this point in the history
super.invalidate() is an empty function in rn >= 0.74, so no
need to call it going forward

But on rn <= 0.73 it may not exist, and if it does it calls
onCatalystInstanceDestroy which makes for a StackOverFlowException
as we go recursive
  • Loading branch information
mikehardy committed Nov 25, 2024
1 parent 0103e12 commit 89904ea
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ public void onCatalystInstanceDestroy() {
// method did not exist before then
@CallSuper
public void invalidate() {
super.invalidate();
executorService.shutdown();
}

Expand Down

0 comments on commit 89904ea

Please sign in to comment.