Merge branch 'main' into v8-deprecations

invertase · Dec 17, 2024 · 99de822 · 99de822
2 parents 43429cb + 3623a50
commit 99de822
Show file tree

Hide file tree

Showing 40 changed files with 197 additions and 113 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+### Bug Fixes
+
+- **android, app:** fix hot-reload on react-native <= 0.73 ([81e5fc2](https://github.com/invertase/react-native-firebase/commit/81e5fc2b6c89fdb4aa5f0f5aa95e1e90dae5f2e4))
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 ### Features

diff --git a/lerna.json b/lerna.json
@@ -76,5 +76,5 @@
     "userUrlFormat": "{{host}}/{{user}}"
   },
   "ignoreChanges": ["**/docs/**", "**/.github/**", "**/e2e/**", "**/tests/**"],
-  "version": "21.6.0"
+  "version": "21.6.1"
 }
diff --git a/packages/analytics/CHANGELOG.md b/packages/analytics/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/analytics
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 ### Bug Fixes

diff --git a/packages/analytics/package.json b/packages/analytics/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/analytics",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - The analytics module provides out of the box support with Google Analytics for Firebase. Integration with the Android & iOS allows for in-depth analytical insight reporting, such as device information, location, user actions and more.",
   "main": "lib/index.js",
@@ -22,7 +22,7 @@
     "analytics"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0"
+    "@react-native-firebase/app": "21.6.1"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/app-check/CHANGELOG.md b/packages/app-check/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/app-check
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/app-check

diff --git a/packages/app-check/package.json b/packages/app-check/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/app-check",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - App Check",
   "main": "lib/index.js",
@@ -25,7 +25,7 @@
     "appCheck"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0",
+    "@react-native-firebase/app": "21.6.1",
     "expo": ">=47.0.0"
   },
   "devDependencies": {

diff --git a/packages/app-distribution/CHANGELOG.md b/packages/app-distribution/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/app-distribution
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/app-distribution

diff --git a/packages/app-distribution/package.json b/packages/app-distribution/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/app-distribution",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - App Distribution",
   "main": "lib/index.js",
@@ -22,7 +22,7 @@
     "app-distribution"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0"
+    "@react-native-firebase/app": "21.6.1"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/app/CHANGELOG.md b/packages/app/CHANGELOG.md
@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+### Bug Fixes
+
+- **android, app:** fix hot-reload on react-native <= 0.73 ([81e5fc2](https://github.com/invertase/react-native-firebase/commit/81e5fc2b6c89fdb4aa5f0f5aa95e1e90dae5f2e4))
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 ### Features

diff --git a/.../android/src/reactnative/java/io/invertase/firebase/common/ReactNativeFirebaseModule.java b/.../android/src/reactnative/java/io/invertase/firebase/common/ReactNativeFirebaseModule.java
@@ -92,12 +92,13 @@ public final ExecutorService getTransactionalExecutor(String identifier) {
     return executorService.getTransactionalExecutor(identifier);
   }
 
-
-  // This is no longer called as of react-native 0.74 and is only here for
-  // compatibility with older versions. It delegates to thew new `invalidate`
+  // On react-native 0.73 this is called, but simply calls `invalidate()`
+  // https://github.com/facebook/react-native/blob/0.73-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java#L65-L72
+  // This is no longer called ever for react-native >= 0.74 and is only here for
+  // compatibility with older versions. We delegate to the new `invalidate`
   // method, which all modules should implement now
   // Remove this method when minimum supported react-native is 0.74
-  /** @noinspection removal*/
+  // @noinspection removal
   @SuppressWarnings({"deprecation", "removal"})
   @Deprecated
   public void onCatalystInstanceDestroy() {
@@ -107,11 +108,14 @@ public void onCatalystInstanceDestroy() {
   }
 
   // This should have an @Override annotation but we cannot do
-  // that until our minimum supported react-native version is 0.74, since the
-  // method did not exist before then
+  // that until our minimum supported react-native version is 0.74
+  //
+  // No need to call super.invalidate and in fact it is dangerous to do so:
+  // - did not exist before react-native 0.73
+  // - on 0.74 it calls onCatalystInstanceDestroy which would infinite loop here
+  // - on 0.75+ it is empty - meant as sub-class hook only
   @CallSuper
   public void invalidate() {
-    super.invalidate();
     executorService.shutdown();
   }
 

diff --git a/packages/app/package.json b/packages/app/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/app",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "A well tested, feature rich Firebase implementation for React Native, supporting iOS & Android. Individual module support for Admob, Analytics, Auth, Crash Reporting, Cloud Firestore, Database, Dynamic Links, Functions, Messaging (FCM), Remote Config, Storage and more.",
   "main": "lib/index.js",

diff --git a/packages/auth/CHANGELOG.md b/packages/auth/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/auth
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/auth

diff --git a/packages/auth/package.json b/packages/auth/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/auth",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - The authentication module provides an easy-to-use API to integrate an authentication workflow into new and existing applications. React Native Firebase provides access to all Firebase authentication methods and identity providers.",
   "main": "lib/index.js",
@@ -27,7 +27,7 @@
     "plist": "^3.1.0"
   },
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0",
+    "@react-native-firebase/app": "21.6.1",
     "expo": ">=47.0.0"
   },
   "devDependencies": {

diff --git a/packages/crashlytics/CHANGELOG.md b/packages/crashlytics/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/crashlytics
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/crashlytics

diff --git a/packages/crashlytics/package.json b/packages/crashlytics/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/crashlytics",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - Firebase Crashlytics is a lightweight, realtime crash reporter that helps you track, prioritize, and fix stability issues that erode your app quality. React Native Firebase provides automatic crash reporting for both native and JavaScript errors, including unhandled promise rejections.",
   "main": "lib/index.js",
@@ -29,7 +29,7 @@
     "crashlytics"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0",
+    "@react-native-firebase/app": "21.6.1",
     "expo": ">=47.0.0"
   },
   "dependencies": {

diff --git a/packages/database/CHANGELOG.md b/packages/database/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/database
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/database

diff --git a/packages/database/package.json b/packages/database/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/database",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - The Firebase Realtime Database is a cloud-hosted database. Data is stored as JSON and synchronized in realtime to every connected client. React Native Firebase provides native integration with the Android & iOS Firebase SDKs, supporting both realtime data sync and offline capabilities.",
   "main": "lib/index.js",
@@ -25,7 +25,7 @@
     "realtome database"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0"
+    "@react-native-firebase/app": "21.6.1"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/dynamic-links/CHANGELOG.md b/packages/dynamic-links/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/dynamic-links
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/dynamic-links

diff --git a/packages/dynamic-links/package.json b/packages/dynamic-links/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/dynamic-links",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - Dynamic Links",
   "main": "lib/index.js",
@@ -25,7 +25,7 @@
     "dynamic link"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0",
+    "@react-native-firebase/app": "21.6.1",
     "expo": ">=47.0.0"
   },
   "devDependencies": {

diff --git a/packages/firestore/CHANGELOG.md b/packages/firestore/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/firestore
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/firestore

diff --git a/packages/firestore/package.json b/packages/firestore/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/firestore",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - Cloud Firestore is a NoSQL cloud database to store and sync data between your React Native application and Firebase's database. The API matches the Firebase Web SDK whilst taking advantage of the native SDKs performance and offline capabilities.",
   "main": "lib/index.js",
@@ -27,7 +27,7 @@
     "firestore"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0"
+    "@react-native-firebase/app": "21.6.1"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/functions/CHANGELOG.md b/packages/functions/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/functions
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/functions

diff --git a/packages/functions/package.json b/packages/functions/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/functions",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - Cloud Functions for Firebase lets you automatically run backend code in response to events triggered by Firebase features and HTTPS requests. React Native Firebase supports integration with production and locally emulated Cloud Functions with a simple API interface.\n\n",
   "main": "lib/index.js",
@@ -24,7 +24,7 @@
     "functions"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0"
+    "@react-native-firebase/app": "21.6.1"
   },
   "devDependencies": {
     "@react-native-firebase/private-tests-firebase-functions": "^0.0.1"

diff --git a/packages/in-app-messaging/CHANGELOG.md b/packages/in-app-messaging/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/in-app-messaging
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/in-app-messaging

diff --git a/packages/in-app-messaging/package.json b/packages/in-app-messaging/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/in-app-messaging",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - Firebase In-App Messaging helps you engage your app's active users by sending them targeted, contextual messages that encourage them to use key app features. React Native Firebase provides support for both native Android & iOS integration with a simple JavaScript API.",
   "main": "lib/index.js",
@@ -27,8 +27,8 @@
     "inAppMessaging"
   ],
   "peerDependencies": {
-    "@react-native-firebase/analytics": "21.6.0",
-    "@react-native-firebase/app": "21.6.0"
+    "@react-native-firebase/analytics": "21.6.1",
+    "@react-native-firebase/app": "21.6.1"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/installations/CHANGELOG.md b/packages/installations/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/installations
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/installations

diff --git a/packages/installations/package.json b/packages/installations/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/installations",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <[email protected]> (http://invertase.io)",
   "description": "React Native Firebase - Installations",
   "main": "lib/index.js",
@@ -22,7 +22,7 @@
     "installations"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.6.0"
+    "@react-native-firebase/app": "21.6.1"
   },
   "publishConfig": {
     "access": "public"

diff --git a/packages/messaging/CHANGELOG.md b/packages/messaging/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+**Note:** Version bump only for package @react-native-firebase/messaging
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 **Note:** Version bump only for package @react-native-firebase/messaging