Skip to content

Commit

Permalink
fix(crashlytics, ios): dependencies init param removed upstream in v11+
Browse files Browse the repository at this point in the history
firebase-ios-sdk v11+ removed one of the parameters from their component initialization API, we must remove it here to use firebase-ios-sdk v11+
  • Loading branch information
mikehardy authored Sep 18, 2024
1 parent daf2bc9 commit ad9439a
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ + (BOOL)isCrashlyticsJavascriptExceptionHandlerChainingEnabled {
FIRComponent *crashlyticsInitProvider =
[FIRComponent componentWithProtocol:@protocol(RNFBCrashlyticsInitProviderProtocol)

Check failure on line 135 in packages/crashlytics/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m

View workflow job for this annotation

GitHub Actions / iOS

no known class method for selector 'componentWithProtocol:instantiationTiming:creationBlock:'
instantiationTiming:FIRInstantiationTimingEagerInDefaultApp
dependencies:@[] // note this will go away in firebase-ios-sdk v11+
creationBlock:creationBlock];

return @[ crashlyticsInitProvider ];
Expand Down

0 comments on commit ad9439a

Please sign in to comment.