fix(remote-config): nits

invertase · Sep 19, 2023 · dacdb4c · dacdb4c
1 parent 3b07778
commit dacdb4c
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 32 deletions.
diff --git a/packages/database/e2e/database.modular.e2e.js b/packages/database/e2e/database.modular.e2e.js
@@ -35,16 +35,6 @@ describe('database()', function () {
       });
     });
 
-    it('supports custom database URL', async function () {
-      firebase.database().app.name.should.eql('[DEFAULT]');
-
-      firebase
-        .database(firebase.app('secondaryFromNative'))
-        .app.name.should.eql('secondaryFromNative');
-
-      firebase.app('secondaryFromNative').database().app.name.should.eql('secondaryFromNative');
-    });
-
     describe('ref()', function () {
       it('throws if path is not a string', async function () {
         try {
@@ -217,7 +207,7 @@ describe('database()', function () {
         const { getDatabase } = databaseModular;
 
         const app = firebase.app();
-        const database = getDatabase();
+        const database = getDatabase(app);
         should.exist(app.database);
         database.app.should.eql(app);
       });
@@ -235,21 +225,6 @@ describe('database()', function () {
       });
     });
 
-    it.skip('supports custom database URL', async function () {
-      // FIXME: the v8 API doesn't seem to have a URL argument
-      throw new Error('Incomplete test');
-
-      // Below is the v8 test, which has nothing to do with custom database URLs
-
-      // firebase.database().app.name.should.eql('[DEFAULT]');
-
-      // firebase
-      //   .database(firebase.app('secondaryFromNative'))
-      //   .app.name.should.eql('secondaryFromNative');
-
-      // firebase.app('secondaryFromNative').database().app.name.should.eql('secondaryFromNative');
-    });
-
     describe('ref()', function () {
       it('throws if path is not a string', async function () {
         const { getDatabase, ref } = databaseModular;

diff --git a/packages/database/lib/modular/index.js b/packages/database/lib/modular/index.js
@@ -89,14 +89,12 @@ export function setPersistenceCacheSizeBytes(db, bytes) {
   return db.setPersistenceCacheSizeBytes(bytes);
 }
 
-// TODO: check if this function is supported on mobile
 export function forceLongPolling() {
-  throw new Error('Unimplemented');
+  throw new Error('forceLongPolling() is not implemented');
 }
 
-// TODO: check if this function is supported on mobile
 export function forceWebSockets() {
-  throw new Error('Unimplemented');
+  throw new Error('forceWebSockets() is not implemented');
 }
 
 /**
@@ -122,5 +120,5 @@ export function increment(delta) {
   return firebase.database.ServerValue.increment(delta);
 }
 
-export * from './api/query';
-export * from './api/transaction';
+export * from './query';
+export * from './transaction';
diff --git a/packages/database/lib/modular/api/query.d.ts → packages/database/lib/modular/query.d.ts b/packages/database/lib/modular/api/query.d.ts → packages/database/lib/modular/query.d.ts
diff --git a/packages/database/lib/modular/api/query.js → packages/database/lib/modular/query.js b/packages/database/lib/modular/api/query.js → packages/database/lib/modular/query.js
diff --git a/...database/lib/modular/api/transaction.d.ts → ...ges/database/lib/modular/transaction.d.ts b/...database/lib/modular/api/transaction.d.ts → ...ges/database/lib/modular/transaction.d.ts
diff --git a/...s/database/lib/modular/api/transaction.js → packages/database/lib/modular/transaction.js b/...s/database/lib/modular/api/transaction.js → packages/database/lib/modular/transaction.js