fix: broken e2e tests

packages/firestore/e2e/WriteBatch/commit.e2e.js

@@ -254,17 +254,17 @@ describe('firestore.WriteBatch.commit()', function () {
     });
 
     it('should set & commit', async function () {
-      const { getFirestore, writeBatch, doc, setDoc, getDoc, deleteDoc } = firestoreModular;
+      const { getFirestore, writeBatch, doc, getDoc, deleteDoc } = firestoreModular;
       const db = getFirestore();
       const lRef = doc(db, `${COLLECTION}/LON`);
       const nycRef = doc(db, `${COLLECTION}/NYC`);
       const sfRef = doc(db, `${COLLECTION}/SF`);
 
       const batch = writeBatch(db);
-
-      setDoc(batch, lRef, { name: 'London' });
-      setDoc(batch, nycRef, { name: 'New York' });
-      setDoc(batch, sfRef, { name: 'San Francisco' });
+      // This is the correct way of setting batch for modular API
+      batch.set(lRef, { name: 'London' });
+      batch.set(nycRef, { name: 'New York' });
+      batch.set(sfRef, { name: 'San Francisco' });
 
       await batch.commit();
 

packages/firestore/lib/FirestoreDocumentReference.js

@@ -20,6 +20,7 @@ import {
   isString,
   isUndefined,
   createDeprecationProxy,
+  filterModularArgument,
 } from '@react-native-firebase/app/lib/common';
 import NativeError from '@react-native-firebase/app/lib/internal/NativeFirebaseError';
 import { parseSetOptions, parseSnapshotArgs, parseUpdateArgs } from './utils';
@@ -197,15 +198,16 @@ export default class FirestoreDocumentReference {
   }
 
   update(...args) {
-    if (args.length === 0) {
+    const updatedArgs = filterModularArgument(args);
+    if (updatedArgs.length === 0) {
       throw new Error(
         'firebase.firestore().doc().update(*) expected at least 1 argument but was called with 0 arguments.',
       );
     }
 
     let data;
     try {
-      data = parseUpdateArgs(args);
+      data = parseUpdateArgs(updatedArgs);
     } catch (e) {
       throw new Error(`firebase.firestore().doc().update(*) ${e.message}`);
     }