-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(storage, ios): enable tests after upstream bug fixes released #7361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fix released upstream
mikehardy
force-pushed
the
@mikehardy/storage-secondary-app-no-events
branch
from
September 20, 2023 14:00
b7e0766
to
3254561
Compare
this test exposed an upstream bug with a fix that will be released in firebase-ios-sdk 10.2.0 - good to merge + release after upstream release
iOS 17 emits a slightly different error when there is nothing to terminate attempting to terminate an app when it is already terminated is not an error, so it is important for detox to recognize the new string iOS17 uses or detox startup fails completely
mikehardy
force-pushed
the
@mikehardy/storage-secondary-app-no-events
branch
from
September 20, 2023 14:25
3254561
to
daf9096
Compare
this check silently fails in CI so some things merge despite needing a re-format - here's a post-merge re-format
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7361 +/- ##
=============================================
- Coverage 68.91% 53.99% -14.92%
- Complexity 0 736 +736
=============================================
Files 137 239 +102
Lines 5708 12013 +6305
Branches 1224 1886 +662
=============================================
+ Hits 3933 6485 +2552
- Misses 1680 5180 +3500
- Partials 95 348 +253 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an older branch I noticed that had two exploratory test cases I used to collaborate with firebase-ios-sdk in order to work through some upstream issues. They are fixed upstream and released now, so we can adopt the tests in our main branch
Patched them up to work with the new modular e2e files since that happened in the interim
Includes 2 random commits that help local testing and don't deserve a separate PR:
Related issues
firebase/firebase-ios-sdk#10370
firebase/firebase-ios-sdk#10463
Release Summary
conventional commits
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
This was all testing / collaboration (via testing...) with firebase-ios-sdk
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter