-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(deps): bump to current RNFB 18.5.0, react-native 0.72.5 #7374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Xcode 15 in github macos-13 image does not include the iPhone 14 simulator (it is available with Xcode 14 and comes as with iOS 16 as a combo) This may have performance impacts on CI and require larger time windows as the iOS 17 simulators seems to have serious performance issues at the moment (spinning diagnosticd processes...)
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
September 27, 2023 16:53
6ba1b05
to
f827ab9
Compare
Currently blocked here - I reproduce the problem locally on a fast machine but not on a slightly slower machine so I suspect it is a timing issue...
|
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
September 28, 2023 16:14
f827ab9
to
a56d1c6
Compare
Required a few changes to source to match breaking changes: - prettier has some slightly different preferences: some code reformatted - firebase-tools firestore emulator disallows some queries now, this specifically required not combining "or" with "not-in" queries
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
September 28, 2023 16:18
a56d1c6
to
6a29816
Compare
mikehardy
changed the title
test(deps): bump to current RNFB 18.5.0, react-native 0.72.5 WIP
test(deps): bump to current RNFB 18.5.0, react-native 0.72.5
Oct 10, 2023
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
October 10, 2023 21:26
afb88a4
to
473483e
Compare
We cannot adopt 10.16.0 right now but many of the transitive inter-dependencies between firebase-ios-sdk components have loose ranges, pulling in some 10.16.0 items
above this version (including v20.8.0) there appears to be some I/O asynchronicity where the file does not exist in time for the chmod command on the file to be issued causing flaky patch generation failures reproducible on linux
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
October 10, 2023 21:57
473483e
to
755c692
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7374 +/- ##
=============================================
- Coverage 68.61% 54.17% -14.44%
- Complexity 0 744 +744
=============================================
Files 145 247 +102
Lines 5855 12160 +6305
Branches 1235 1897 +662
=============================================
+ Hits 4017 6586 +2569
- Misses 1743 5232 +3489
- Partials 95 342 +247 |
Vercel needed a project settings bump from node v16 to node v18 for this as well |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump to RNFB-current + react-native-current as a first commit
going to bump any easy javascript dependencies in a second commit
Related issues
@exaby73 mentioned he has had difficulties compiling the test app due to needing
-ld64
on Xcode 15, but I haven't experienced this. It is apparently a common issue with C++ libraries as they rely on weak linking and Xcode 15 deprecated that / turned it off by default, but I have not personally experienced it. Nevertheless, react-native 0.72.5 (vs 0.72.4) contains a number of Xcode 15 compatibility fixes that are linker-related (namely: switching to the classic linker vs the new Xcode 15 linker) so perhaps this allows things to workRelease Summary
No release should be triggered, this will be marked as non-release-worthy via conventional commits
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
It's all test app work...
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter