Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(deps): bump to current RNFB 18.5.0, react-native 0.72.5 #7374

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

mikehardy
Copy link
Collaborator

Description

Bump to RNFB-current + react-native-current as a first commit

going to bump any easy javascript dependencies in a second commit

Related issues

@exaby73 mentioned he has had difficulties compiling the test app due to needing -ld64 on Xcode 15, but I haven't experienced this. It is apparently a common issue with C++ libraries as they rely on weak linking and Xcode 15 deprecated that / turned it off by default, but I have not personally experienced it. Nevertheless, react-native 0.72.5 (vs 0.72.4) contains a number of Xcode 15 compatibility fixes that are linker-related (namely: switching to the classic linker vs the new Xcode 15 linker) so perhaps this allows things to work

Release Summary

No release should be triggered, this will be marked as non-release-worthy via conventional commits

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

It's all test app work...


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 11:46pm
react-native-firebase-next ❌ Failed (Inspect) Oct 10, 2023 11:46pm

Xcode 15 in github macos-13 image does not include the
iPhone 14 simulator (it is available with Xcode 14 and
comes as with iOS 16 as a combo)

This may have performance impacts on CI and require larger
time windows as the iOS 17 simulators seems to have serious
performance issues at the moment (spinning diagnosticd processes...)
@mikehardy
Copy link
Collaborator Author

Currently blocked here - I reproduce the problem locally on a fast machine but not on a slightly slower machine so I suspect it is a timing issue...


  1) firestore().namedQuery()
       modular
         limits the number of documents in bundled QuerySnapshot:

      AssertionError: expected 0 to be 1
      + expected - actual

      -0
      +1

Required a few changes to source to match breaking changes:

- prettier has some slightly different preferences: some code reformatted
- firebase-tools firestore emulator disallows some queries now,
  this specifically required not combining "or" with "not-in" queries
We cannot adopt 10.16.0 right now but many of the transitive inter-dependencies
between firebase-ios-sdk components have loose ranges, pulling in some 10.16.0
items
above this version (including v20.8.0) there appears to be some I/O
asynchronicity where the file does not exist in time for the chmod command
on the file to be issued causing flaky patch generation failures

reproducible on linux
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #7374 (755c692) into main (c9b695a) will decrease coverage by 14.44%.
The diff coverage is 0.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #7374       +/-   ##
=============================================
- Coverage     68.61%   54.17%   -14.44%     
- Complexity        0      744      +744     
=============================================
  Files           145      247      +102     
  Lines          5855    12160     +6305     
  Branches       1235     1897      +662     
=============================================
+ Hits           4017     6586     +2569     
- Misses         1743     5232     +3489     
- Partials         95      342      +247     

@mikehardy
Copy link
Collaborator Author

Vercel needed a project settings bump from node v16 to node v18 for this as well

@mikehardy mikehardy merged commit 3dca3c1 into main Oct 10, 2023
14 of 16 checks passed
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch October 10, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant