Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(remote-config): error param for onConfigUpdated may be undefined but not null #7438

Conversation

JasonPan
Copy link

@JasonPan JasonPan commented Nov 6, 2023

Description

Minor fix for docs - the error param cannot be null, should be checking for undefined. The e2e tests confirm this behaviour.

I thought something else in my code was wrong, so will save a min or two for the next user if we correct this.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 1:55pm
react-native-firebase-next ❌ Failed (Inspect) Nov 6, 2023 1:55pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo - sorry about that! Thank you for the fix.
Looks like the CLA still needs signing before I can merge? You may follow the details link on that CI check and it will step you through it I believe

@mikehardy mikehardy changed the title Fix docs for onConfigUpdated error check docs(remote-config): error param for onConfigUpdated may be undefined but not null Nov 6, 2023
@mikehardy
Copy link
Collaborator

superceded by #7471

@mikehardy mikehardy closed this Nov 27, 2023
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants