Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(messaging, server-integration): document new / non-deprecated APIs / JSON fields #7448

Merged
merged 3 commits into from
Nov 8, 2023
Merged

docs(messaging, server-integration): document new / non-deprecated APIs / JSON fields #7448

merged 3 commits into from
Nov 8, 2023

Conversation

drewxs
Copy link
Contributor

@drewxs drewxs commented Nov 8, 2023

Description

  • Deprecated API: sendToDevice
  • Correct Message field names:
    • fcm_options -> fcmOptions
    • image -> imageUrl.

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Just docs.

🔥

@drewxs
docs(server-integration): fix deprecated APIs and fields
38583cb 
sendToDevice deprecated, use sendMulticast or sendEachForMulticast instead for sending messages to multiple devices.
Correct field names: fcm_options->fcmOptions, image->imageUrl.
@vercel Vercel
Copy link

vercel bot commented Nov 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 9:58pm
react-native-firebase-next ❌ Failed (Inspect) Nov 8, 2023 9:58pm

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mikehardy
mikehardy previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!
CI always has something to about spelling and formatting but I can shepherd that through and get it merged as long as the CLA is signed

docs/messaging/server-integration.md Show resolved Hide resolved
@mikehardy mikehardy changed the title docs(server-integration): fix deprecated APIs and fields docs(messaging, server-integration): document new / non-deprecated APIs / JSON fields Nov 8, 2023
@mikehardy
style(lint): yarn lint:markdown --write
45abd79 
my own suggestion had poor formatting
@mikehardy mikehardy merged commit 2c1127a into invertase:main Nov 8, 2023
8 checks passed
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehardy mikehardy mikehardy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewxs @CLAassistant @mikehardy