Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adopt firebase-ios-sdk 10.18.0 / firebase-android-sdk 32.6.0 #7467

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

mikehardy
Copy link
Collaborator

also bump all javascript dependencies and yarn

for some reason react-native cli was not executable so switched it to the default yarn react-native style - people no longer install react-native globally so this should work well in the modern era

updated yarn to 4.0.2

also bump all javascript dependencies and yarn
Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 1:44pm
react-native-firebase-next ❌ Failed (Inspect) Nov 23, 2023 1:44pm

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #7467 (7263e02) into main (b9140b2) will increase coverage by 30.81%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

❗ Current head 7263e02 differs from pull request most recent head 3467a72. Consider uploading reports for the commit 3467a72 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #7467       +/-   ##
=============================================
+ Coverage     22.92%   53.72%   +30.81%     
- Complexity        0      738      +738     
=============================================
  Files           130      248      +118     
  Lines          5443    12163     +6720     
  Branches       1235     1897      +662     
=============================================
+ Hits           1247     6533     +5286     
- Misses         3511     5279     +1768     
+ Partials        685      351      -334     

this was speculative earlier when Xcode changed and
simulator list changed, to discover what was available

it takes approximately a minute though and is not worth
the delay normally
@mikehardy mikehardy merged commit 124619e into main Nov 23, 2023
17 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch November 23, 2023 16:06
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant