fix(database): react-native 0.73 compatibility #7500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upstream EventEmitter made registrations fully private, and we were relying on them to implement specific-listener-removal to meet a firebase-js-sdk API contract implemented listener registration accounting in situ in place of previous style relying on upstream EventEmitter implementation
previous timeout function appeared to use network which caused problems with iOS insecure network loads
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9 tasks
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
5209810 to
3339f67
Compare
- java --> kotlin in this release of react-native
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
3339f67 to
a2b5fd1
Compare
|
Took a couple of polishing tweaks but this time should go green and can release tomorrow morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is mostly adopting react-native 0.73 in our test app and then fixing an incompatibility I noticed in the way we use EventEmitter in the database module
I moved one functions test (timeout handling) to be in the emulator vs the cloud
We adopt firebase-ios-sdk 10.19.0 but we haven't integrated underlying changes so this isn't really a user-visible change
The rest is just dependency updates
Release Summary
conventional commits
Test Plan
Lots and lots of e2e runs locally
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter