Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crashlytics, ios): dependencies init param removed upstream in v11+ #8025

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

firebase-ios-sdk v11+ removed one of the parameters from their component initialization API, we must remove it here to use firebase-ios-sdk v11+

Related issues

The fix for the Xcode build failures on Xcode 16+ require using firebase-ios-sdk v11+, which requires this:

Release Summary

This is a conventional commit so should be possible to rebase merge

NOTE THAT package.json needs firebase bumped to 11.2.0 as a commit before this one works - however, that is not a breaking change, if you bump package.json to 11.2.0 for firebase-ios-sdk, and merge this PR plus #8021 then react-native-firebase appears to work fine

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No not by itself but must be issued with bump to firebase-ios-sdk v11

Test Plan

tested in https://github.com/mikehardy/rnfbdemo/blob/main/make-demo.sh with a patch, a bump to firebase-ios-sdk and a patch from #8021


Think react-native-firebase is great? Please consider supporting the project with any of the below:

firebase-ios-sdk v11+ removed one of the parameters from their component initialization API, we must remove it here to use firebase-ios-sdk v11+
Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 2:04pm

@mikehardy mikehardy requested a review from dackers86 September 18, 2024 17:25
@Salakar Salakar changed the base branch from main to bump-ios-sdk September 19, 2024 13:12
@Salakar Salakar merged commit c1dc501 into bump-ios-sdk Sep 19, 2024
18 of 20 checks passed
@Salakar Salakar deleted the crashlytics-init-sdk-v11 branch September 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants