Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios, sdk): adopt firebase-ios-sdk 11.3.0 #8042

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

mikehardy
Copy link
Collaborator

Description

A simple bump to the firebase-ios-sdk per request from @efstathiosntonas

Related issues

None logged

Release Summary

single conventional commit

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

CI should validate it


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 2:53am

@mikehardy
Copy link
Collaborator Author

Note that firestore-ios-sdk-frameworks does not have an 11.3.0 in the works, this was a simple change to a single character in package.json but that's more involved, and I am not personally involved so I have no control over that one

Not sure if it's possible to just override your firebase-ios-sdk version locally @efstathiosntonas in the Podfile (perhaps with an expo plugin doing an unsafe edit literally anywhere in the file, like just adding a line at the top that has the override variable?)

@efstathiosntonas
Copy link
Contributor

efstathiosntonas commented Oct 1, 2024

Hi Mike, I've been always pinning firebase on my Podfile, I never bump them before you release an rn-firebase for the reasons you mentioned above, can't tell if there are breaking changes or not on our side that's why I pinged you on ios-sdk repo.

	$FirebaseSDKVersion = '11.3.0'
	pod 'FirebaseAppCheckInterop', '=' + "11.3.0"
	pod 'FirebaseAuthInterop', '=' + "11.3.0"
	pod 'FirebaseMessagingInterop', '=' + "11.3.0"
	pod 'FirebaseSharedSwift', '=' + "11.3.0"
	pod 'FirebaseCoreInternal', '=' + "11.3.0"
	pod 'FirebaseInstallations', '=' + "11.3.0"
	pod 'FirebaseCoreExtension', '=' + "11.3.0"

I've built the app but it crashed on boot, felt the same crash like with 11.2.0, unfortunately I built on command line so no Xcode trace. Tried to create more builds on different devices but couldn't reproduce the crash, will keep trying. Given the fact that ios crashes on boot are extremely rare I'm afraid this is 11.3.0 issue again(?).

I don't think we should merge this until ios-sdk repo issue has more feedback from more devs.

@efstathiosntonas
Copy link
Contributor

fear came true, seems it's not fixed:

Screenshot 2024-10-01 at 08 36 59

@mikehardy
Copy link
Collaborator Author

This should be good to go now that firestore-ios-sdk-frameworks 11.3.0 is published and seems to be working well
Cheers!

@mikehardy mikehardy merged commit 4b06b7b into main Oct 21, 2024
18 of 19 checks passed
@mikehardy mikehardy deleted the @mikehardy/firebase-ios-sdk-11-3-0 branch October 21, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants