feat: support custom firebase.json path

[CHOIMINSEOK]

Description

Currently, the firebase.json file is configured only when it is located in the parent directory of the Android project. However, React Native can be used in different ways, especially when integrating it into an existing native project.

In my case, I’m trying to integrate a React Native app into a brownfield native app as a submodule, so retrieving firebase.json from the upper directory always fails. I think providing an option to set a custom "firebaseJsonDir" would be very useful for people in my situation.

I add "customFirebaseJsonDir" option in same way to override firebase sdk versions and reactNativeDir.

I would appreciate any help to add this feature on iOS too.

Release Summary

• Support custom firebase.json path

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2024 1:01pm

[CLAassistant]

All committers have signed the CLA.

[mikehardy]

Hmm - the iOS side does a search for firebase.json in two places:

1- one in shell script installed as a build script inside the Xcode project, during build in order to pull values that it needs to put in the Info.plist:

react-native-firebase/packages/app/ios_config.sh

Lines 77 to 87 in d55e891

	while true; do
	_CURRENT_SEARCH_DIR=$(dirname "$_CURRENT_SEARCH_DIR")
	if [[ "$_CURRENT_SEARCH_DIR" == "/" ]] || [[ ${_CURRENT_LOOKUPS} -gt ${_MAX_LOOKUPS} ]]; then break; fi;
	echo "info: ($_CURRENT_LOOKUPS of $_MAX_LOOKUPS) Searching in '$_CURRENT_SEARCH_DIR' for a ${_JSON_FILE_NAME} file."
	_SEARCH_RESULT=$(find "$_CURRENT_SEARCH_DIR" -maxdepth 2 -name ${_JSON_FILE_NAME} -print | /usr/bin/head -n 1)
	if [[ ${_SEARCH_RESULT} ]]; then
	echo "info: ${_JSON_FILE_NAME} found at $_SEARCH_RESULT"
	break;
	fi;
	_CURRENT_LOOKUPS=$((_CURRENT_LOOKUPS+1))
	done

2- one in ruby which is pulled in to the RNFBApp podspec to get the SDK versions

react-native-firebase/packages/app/firebase_json.rb

Lines 35 to 59 in d55e891

	i = 0
	while i < 5
	current_search_directory = File.join(current_search_directory, '..')
	if is_test_project
	firebase_json = File.expand_path(File.join(current_search_directory, 'tests', 'firebase.json'))
	else
	firebase_json = File.expand_path(File.join(current_search_directory, 'firebase.json'))
	end
	if File.exist?(firebase_json)
	$firebase_json_path = firebase_json
	begin
	$firebase_json_config = JSON.parse(File.read(firebase_json))['react-native']
	Pod::UI.puts "Using firebase.json from '#{firebase_json}'"
	# Pod::UI.puts $firebase_json_config
	rescue => error
	Pod::UI.warn "An error occurred parsing the firebase.json located at '#{firebase_json}':"
	Pod::UI.warn error
	end
	break
	end
	i += 1
	end
	end

I am not sure how to transmit to the Xcode build script that you have a specific firebase.json path, the only thing I can think of is an environment variable. For firebase_json.rb it could be a Podfile variable perhaps

I wonder if, in all these cases, it might be easier as part of your build / package process to determine which directories are actually being searched...and during build make sure the firebase.json is just copied/placed into a directory that is already searched?

That might be easier than complicating the build / config process here (which is already pretty touchy...)

[CHOIMINSEOK]

Hi! @mikehardy Thanks for reply.

I wonder if, in all these cases, it might be easier as part of your build / package process to determine which directories are actually being searched...and during build make sure the firebase.json is just copied/placed into a directory that is already searched?

Yeah that might work, but all of those who have different rn app structure have to feature out where the build script of react-native-firebase resolves firebase.json. I just want to provide a convenient option for them. Besides, in some case like me the location might be outside of project which is so weird.

directory <= this is where react-native-firebase starts to resolve firebase.json
 ㄴ android project
  ㄴ react native project

[github-actions]

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically